Do not include the shared framework in the packages #24816
Conversation
DevServer and dotnet-watch include binaries from the ASP.NET Core shared framework as part of the package. This change compiles these projects against the most recently built version of the shared framework which ensures build and publish work as normals. Individual projects from the runtime can be referenced to pick up new runtime features when necessary
...nents/WebAssembly/DevServer/src/Microsoft.AspNetCore.Components.WebAssembly.DevServer.csproj
Show resolved
Hide resolved
Pilchie
added
area-commandlinetools
|
Updated based on our conversation. Like I mentioned offline, I'd like to look at moving |
| <Reference Include="Selenium.Support" /> | ||
| <Reference Include="Selenium.WebDriver" /> | ||
| <ProjectReference Include="..\..\..\WebAssembly\DevServer\src\Microsoft.AspNetCore.Components.WebAssembly.DevServer.csproj" /> |
There was a problem hiding this comment.
Just curious: Why compile in these files instead of referencing the project❔ Should the files be moved into a Shared directory❔
There was a problem hiding this comment.
I'm also curious about that :)
My guess is it's something nonobvious about having to run it inside docker. Perhaps @pranavkm can clarify.
There was a problem hiding this comment.
Sorry, I completely lost track of this PR. The M.AspNetCore.App reference in the DevServer project is viral, any project that references it also needs to be able to resolve that reference. Compiling the relevant types by source avoids any further hacks.
| <file src="$OutputPath$dotnet-watch.pdb" target="tools\$DefaultNetCoreTargetFramework$\any\dotnet-watch.pdb" /> | ||
| <file src="$BrowserRefreshOutputPath$Microsoft.AspNetCore.Watch.BrowserRefresh.dll" target="tools\$DefaultNetCoreTargetFramework$\any\middleware\Microsoft.AspNetCore.Watch.BrowserRefresh.dll" /> | ||
| </files> | ||
| </package> |
There was a problem hiding this comment.
I don't think this file will be used. Suggest removing the PopulateNuspec target and adding a $(NuspecFile) setting in the project file if you want this instead of the auto-generated file.
There was a problem hiding this comment.
You're right. This can be removed.
|
|
||
| <ProjectReference |
There was a problem hiding this comment.
nit: Might be worth a comment about ensuring the latest framework bits exist before resolving the framework ref.
There was a problem hiding this comment.
This all looks completely plausible and I'm confident that @pranavkm is the right person to make calls about these changes. Pranav, if you think there's anything uncertain about the validity of these changes then please speak up, otherwise as far as I'm concerned, if it works then let's ship it :)
- allow sharedFx assemblies in Microsoft.AspNetCore.Components.WebAssembly.DevServer package - see #26448 about reducing this baggage later in 6.0
- allow sharedFx assemblies in Microsoft.AspNetCore.Components.WebAssembly.DevServer package - see #26448 about reducing this baggage later in 6.0
* Update branding to 6.0.0 Alpha1 - hold the TFM back at `net5.0` - correct `TargetFrameworkVersion` in FrameworkList.xml; don't use `$(AspNetCoreMajorMinorVersion)` - move `$(DefaultNetCoreTargetFramework)` to eng/Versions.props - avoid repeating value in AfterSolutionBuild.targets and Directory.Build.props files - add new versions to `TemplatePackageInstaller` - update project template test scripts * Update / add 6.0 package versions in test expectations - basically, remove test assumptions that branding == target TFM - `TestData` will need another update once 6.0.0.0 assembly versions arrive from dotnet/runtime * Update `Condition`s on `@(SuppressBaselineReference)` items to 6.0 * Undo some of #24816 - allow sharedFx assemblies in Microsoft.AspNetCore.Components.WebAssembly.DevServer package - see #26448 about reducing this baggage later in 6.0 * Skip IndividualAuth tests on Helix - #26776
* Update branding to 6.0.0 Alpha1 - hold the TFM back at `net5.0` - correct `TargetFrameworkVersion` in FrameworkList.xml; don't use `$(AspNetCoreMajorMinorVersion)` - move `$(DefaultNetCoreTargetFramework)` to eng/Versions.props - avoid repeating value in AfterSolutionBuild.targets and Directory.Build.props files - add new versions to `TemplatePackageInstaller` - update project template test scripts * Update / add 6.0 package versions in test expectations - basically, remove test assumptions that branding == target TFM - `TestData` will need another update once 6.0.0.0 assembly versions arrive from dotnet/runtime * Update `Condition`s on `@(SuppressBaselineReference)` items to 6.0 * Undo some of dotnet/aspnetcore#24816 - allow sharedFx assemblies in Microsoft.AspNetCore.Components.WebAssembly.DevServer package - see dotnet/aspnetcore#26448 about reducing this baggage later in 6.0 * Skip IndividualAuth tests on Helix - dotnet/aspnetcore#26776 Commit migrated from dotnet/aspnetcore@da7fead48635
DevServer and dotnet-watch include binaries from the ASP.NET Core shared framework
as part of the package. This change compiles these projects against the most recently built
version of the shared framework which ensures build and publish work as normals. Individual
projects from the runtime can be referenced to pick up new runtime features when necessary