Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge preview8 branch to public #25280
Merge preview8 branch to public #25280
Changes from 47 commits
f5538cb
609b55f
77435c3
3ad9e57
869d8f5
542031b
6654c8f
ab7a11f
f437647
c88efce
2bac45c
43b68e3
dc3a864
716598e
2827037
670f952
4d23ec0
21a5f39
cba2275
864a292
3e7a106
6c665aa
f172d20
4581307
c60c278
f22aa71
5dc9931
fed1953
d2ccb49
06fbd7e
3516b8d
6aa8cec
7f8e21f
a1df872
929a89b
cb4a16a
b8e176e
a4938d0
6205d66
663915b
b32dfa8
f883065
72a7635
96b1c23
e6a163b
08309b1
b02309f
d1ab8ef
cd0ec1f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized after doing this that we probably don't need to add as many sources in eng/helix/content/RunTests/TestRunner.cs anymore. That file also adds a bunch of environment variables that are set in the
runtests.*
scripts. Please file a follow-up issue for cleanup after this goes in. Or, just open another PR to remove the redundancy.I'm keeping this separate because it's not really part of the merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @JunTaoLuo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plz file follow-up issue(s) to
TestRunner
NuGet source additions that should already be in this file (copied from the build and, likely enhanced in the case of internal builds)TestRunner
and theruntests.*
scripts if possibledotnet-install.*
scripts from eng/common/dotnet-install-scripts/ to the Helix payload (placing them in a dotnet-install-scripts/ folder relative to where thetools.*
files landThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed the third bullet in my commit to your branch @wtgodbe