Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Readme for Framework #27918

Merged
merged 10 commits into from
Nov 20, 2020
Merged

Add Readme for Framework #27918

merged 10 commits into from
Nov 20, 2020

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Nov 17, 2020

Part of #27561

@dotnet/aspnet-build is this area owned by you guys? Not sure who's best to review.

@HaoK HaoK requested a review from a team November 17, 2020 21:39
@ghost ghost added the feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform label Nov 17, 2020
@HaoK
Copy link
Member Author

HaoK commented Nov 17, 2020

@Rick-Anderson for edits

src/Framework/README.md Outdated Show resolved Hide resolved
src/Framework/README.md Outdated Show resolved Hide resolved
src/Framework/README.md Outdated Show resolved Hide resolved
HaoK and others added 3 commits November 17, 2020 14:49
Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
src/Framework/README.md Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Nov 17, 2020

Hello @HaoK!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

src/Framework/README.md Outdated Show resolved Hide resolved
src/Framework/README.md Outdated Show resolved Hide resolved
src/Framework/README.md Show resolved Hide resolved
@HaoK HaoK removed the auto-merge label Nov 18, 2020
src/Framework/README.md Outdated Show resolved Hide resolved
src/Framework/README.md Outdated Show resolved Hide resolved
src/Framework/README.md Outdated Show resolved Hide resolved
Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One touch up and you're done 😺

src/Framework/README.md Outdated Show resolved Hide resolved
Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
@HaoK
Copy link
Member Author

HaoK commented Nov 18, 2020

Thanks @dougbu

@HaoK HaoK merged commit 5d411aa into master Nov 20, 2020
@HaoK HaoK deleted the haok/fxdocs branch November 20, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants