Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add README.md for JSInterop #28074

Merged
merged 9 commits into from
Nov 25, 2020
Merged

Add README.md for JSInterop #28074

merged 9 commits into from
Nov 25, 2020

Conversation

SteveSandersonMS
Copy link
Member

Part of #27561

@SteveSandersonMS SteveSandersonMS requested review from guardrex and a team November 23, 2020 10:47
guardrex
guardrex approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor nits.

I'm not applying all of the tiny little doc concepts (e.g., 2nd person and future tense, pronouns, API doc cross-links, unpaired heading, etc.). These suggestions are just the better nits for a README. 😄

src/JSInterop/README.md Outdated Show resolved Hide resolved
src/JSInterop/README.md Outdated Show resolved Hide resolved
src/JSInterop/README.md Outdated Show resolved Hide resolved
src/JSInterop/README.md Outdated Show resolved Hide resolved
src/JSInterop/README.md Outdated Show resolved Hide resolved
src/JSInterop/README.md Outdated Show resolved Hide resolved
SteveSandersonMS and others added 6 commits November 23, 2020 19:10
@SteveSandersonMS @guardrex
Update src/JSInterop/README.md
4651021 
Co-authored-by: Luke Latham <llatham@aquent.com>
@SteveSandersonMS @guardrex
Update src/JSInterop/README.md
4e3fcc1 
Co-authored-by: Luke Latham <llatham@aquent.com>
@SteveSandersonMS @guardrex
Update src/JSInterop/README.md
8d926c2 
Co-authored-by: Luke Latham <llatham@aquent.com>
@SteveSandersonMS @guardrex
Update src/JSInterop/README.md
b414120 
Co-authored-by: Luke Latham <llatham@aquent.com>
@SteveSandersonMS @guardrex
Update src/JSInterop/README.md
ee0ee90 
Co-authored-by: Luke Latham <llatham@aquent.com>
@SteveSandersonMS @guardrex
Update src/JSInterop/README.md
a0474fa 
Co-authored-by: Luke Latham <llatham@aquent.com>
@SteveSandersonMS
Copy link
Member Author

Thanks @guardrex!

@Pilchie Pilchie added area-blazor Includes: Blazor, Razor Components area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Nov 23, 2020
captainsafia
captainsafia approved these changes Nov 23, 2020
View reviewed changes
src/JSInterop/README.md Outdated Show resolved Hide resolved
@SteveSandersonMS @captainsafia
Update src/JSInterop/README.md
d8bb0f1 
Co-authored-by: Safia Abdalla <safia@microsoft.com>
@SteveSandersonMS SteveSandersonMS merged commit 54e9c76 into master Nov 25, 2020
@SteveSandersonMS SteveSandersonMS deleted the stevesa/readme-for-jsinterop branch November 25, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia approved these changes

@guardrex guardrex guardrex approved these changes

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SteveSandersonMS @guardrex @captainsafia @Pilchie