Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SignalR] Remove obsolete APIs #28100

Merged
merged 1 commit into from
Jan 4, 2021
Merged

[SignalR] Remove obsolete APIs #28100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/SignalR/common/Http.Connections.Common/src/NegotiateProtocol.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,16 +258,6 @@ public static NegotiationResponse ParseResponse(ReadOnlySpan<byte> content)
}
}

/// <summary>
/// <para>
/// This method is obsolete and will be removed in a future version.
/// The recommended alternative is <see cref="ParseResponse(ReadOnlySpan{byte})" />.
/// </para>
/// </summary>
[Obsolete("This method is obsolete and will be removed in a future version. The recommended alternative is ParseResponse(ReadOnlySpan{byte}).")]
public static NegotiationResponse ParseResponse(Stream content) =>
throw new NotSupportedException("This method is obsolete and will be removed in a future version. The recommended alternative is ParseResponse(ReadOnlySpan{byte}).");

private static AvailableTransport ParseAvailableTransport(ref Utf8JsonReader reader)
{
var availableTransport = new AvailableTransport();
Expand Down
1 change: 0 additions & 1 deletion src/SignalR/common/Http.Connections.Common/src/PublicAPI.Shipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,5 @@ static readonly Microsoft.AspNetCore.Http.Connections.HttpTransports.All -> Micr
~Microsoft.AspNetCore.Http.Connections.NegotiationResponse.Error.set -> void
~Microsoft.AspNetCore.Http.Connections.NegotiationResponse.Url.get -> string
~Microsoft.AspNetCore.Http.Connections.NegotiationResponse.Url.set -> void
~static Microsoft.AspNetCore.Http.Connections.NegotiateProtocol.ParseResponse(System.IO.Stream content) -> Microsoft.AspNetCore.Http.Connections.NegotiationResponse
~static Microsoft.AspNetCore.Http.Connections.NegotiateProtocol.ParseResponse(System.ReadOnlySpan<byte> content) -> Microsoft.AspNetCore.Http.Connections.NegotiationResponse
~static Microsoft.AspNetCore.Http.Connections.NegotiateProtocol.WriteResponse(Microsoft.AspNetCore.Http.Connections.NegotiationResponse response, System.Buffers.IBufferWriter<byte> output) -> void
12 changes: 0 additions & 12 deletions src/SignalR/server/Core/src/HubInvocationContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,6 @@ public HubInvocationContext(HubCallerContext context, IServiceProvider servicePr
Context = context;
}

/// <summary>
/// Instantiates a new instance of the <see cref="HubInvocationContext"/> class.
/// </summary>
/// <param name="context">Context for the active Hub connection and caller.</param>
/// <param name="hubMethodName">The name of the Hub method being invoked.</param>
/// <param name="hubMethodArguments">The arguments provided by the client.</param>
[Obsolete("This constructor is obsolete and will be removed in a future version. The recommended alternative is to use the other constructor.")]
public HubInvocationContext(HubCallerContext context, string hubMethodName, object?[] hubMethodArguments)
{
throw new NotSupportedException("This constructor no longer works. Use the other constructor.");
}

internal HubInvocationContext(ObjectMethodExecutor objectMethodExecutor, HubCallerContext context, IServiceProvider serviceProvider, Hub hub, object?[] hubMethodArguments)
: this(context, serviceProvider, hub, objectMethodExecutor.MethodInfo, hubMethodArguments)
{
Expand Down
1 change: 0 additions & 1 deletion src/SignalR/server/Core/src/PublicAPI.Shipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ Microsoft.AspNetCore.SignalR.HubInvocationContext
Microsoft.AspNetCore.SignalR.HubInvocationContext.Context.get -> Microsoft.AspNetCore.SignalR.HubCallerContext!
Microsoft.AspNetCore.SignalR.HubInvocationContext.Hub.get -> Microsoft.AspNetCore.SignalR.Hub!
Microsoft.AspNetCore.SignalR.HubInvocationContext.HubInvocationContext(Microsoft.AspNetCore.SignalR.HubCallerContext! context, System.IServiceProvider! serviceProvider, Microsoft.AspNetCore.SignalR.Hub! hub, System.Reflection.MethodInfo! hubMethod, System.Collections.Generic.IReadOnlyList<object?>! hubMethodArguments) -> void
Microsoft.AspNetCore.SignalR.HubInvocationContext.HubInvocationContext(Microsoft.AspNetCore.SignalR.HubCallerContext! context, string! hubMethodName, object?[]! hubMethodArguments) -> void
Microsoft.AspNetCore.SignalR.HubInvocationContext.HubMethod.get -> System.Reflection.MethodInfo!
Microsoft.AspNetCore.SignalR.HubInvocationContext.HubMethodArguments.get -> System.Collections.Generic.IReadOnlyList<object?>!
Microsoft.AspNetCore.SignalR.HubInvocationContext.HubMethodName.get -> string!
Expand Down