Follow-up to cleaning up obsolete types in Razor #28706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
ajaybhargavb
approved these changes
Dec 17, 2020
pranavkm
reviewed
Dec 18, 2020
src/Razor/Microsoft.AspNetCore.Mvc.Razor.Extensions/src/InjectDirective.cs
Outdated
Show resolved
Hide resolved
pranavkm
approved these changes
Dec 18, 2020
|
Hello @captainsafia! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Announcement: aspnet/Announcements#446 |
ghost
merged commit
dougbu
pushed a commit
to dougbu/razor-compiler
that referenced
this pull request
Nov 17, 2021
…8706) * Follow-up to cleaning up obsolete types in Razor * Revert "Follow-up to cleaning up obsolete types in Razor" This reverts commit 0ccc3d647ece17efef96d5a33ed578eeb26f1fee. * Address feedback from peer review Commit migrated from dotnet/aspnetcore@90febebe4c12
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #27529.
This PR is a follow-up to #28418. Removing all the references to RazorEngine ended up being a fair significant chunk of work so I've pulled it out of this for now.
This PR covers the things discussed during the API review:
GetIteminterface per @NTaylorMullen's recommendation here.IRazorEngineBuilderin directives in V1_x and V2_x.IRazorEngineBuilderextensions.RazorEngine. The cost of removing all the references in the V1_x and V2_x projects and in the types in favor of RazorProjectEngine turned out to be pretty high so I opted not to do this. Tracking this here in case we want to invest time in this.