Make IncrementallyUpdatesCache and CachesResourcesAfterFirstLoad tests more robust. Hopefully fixes #20154 #29091
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know for certain why these tests occasionally fail, because they pass ~98% of the time in CI, and 100% of the times I've tried running locally.
However I notice that the collection in which we track the requested URLs is not thread-safe, and is potentially written from multiple threads concurrently. This could explain why sometimes we don't find the expected URLs in the collection.
I've also added a second tweak to make sure that, when we navigate to
about:blank
, we wait until that navigation is completed before proceeding to re-navigate back to where we came from.