Use string.Create to build absolute URI #29448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Doesn't compile? |
paulomorgado
force-pushed
the
paulomorgado/issue-28905
branch
from
4bc7fce to
aaa5ecc
Compare
paulomorgado
changed the title
|
Sorry about that. It was a bad copy+past and I still haven't mastered the art of working with this code base. |
Tratcher
reviewed
Jan 22, 2021
BrennanConroy
added
the
community-contribution
paulomorgado
force-pushed
the
paulomorgado/issue-28905
branch
2 times, most recently
from
42c84ea to
9a21cd8
Compare
Tratcher
reviewed
Jan 25, 2021
paulomorgado
force-pushed
the
paulomorgado/issue-28905
branch
from
9a21cd8 to
e82f0b2
Compare
Tratcher
approved these changes
Jan 26, 2021
|
Hello @Tratcher! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
|
Thanks. |
|
Hi @Tratcher. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
amcasey
added
area-networking
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
Use string.Creat to build absolute URI.
PR Description
UriHelper.BuildAbsolutecreates an intermediary string for the combined path that is used only for concatenating with the other components to create the final URL.It also uses a non-pooled
StringBuilderthat is instantiated on every invocation. Although optimized in size, it is a heap allocation with an intermediary buffer.Using
string.Createwill bring a significant performance improvement.Fixes #28905