Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for extraQueryParameters in Blazor WASM / MSAL #30798

Closed
wants to merge 1 commit into from
Closed

Support for extraQueryParameters in Blazor WASM / MSAL #30798

wants to merge 1 commit into from

Conversation

ma3yta
Copy link

@ma3yta ma3yta commented Mar 10, 2021 •
edited
Loading

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Fix for #25391

@ma3yta ma3yta requested a review from a team as a code owner March 10, 2021 07:49
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Mar 10, 2021
@dnfadmin
Copy link

dnfadmin commented Mar 10, 2021 •
edited
Loading

CLA assistant check
All CLA requirements met.

@Pilchie Pilchie added the community-contribution Indicates that the PR has been added by a community member label Mar 18, 2021
@Pilchie
Copy link
Member

Pilchie commented Mar 18, 2021

@mkArtakMSFT - can this be assigned to someone to take a look at?

javiercn
javiercn reviewed Mar 19, 2021
View reviewed changes
src/Components/WebAssembly/WebAssembly.Authentication/src/Models/RemoteAuthenticationState.cs
/// <summary>
/// Gets or sets additional query parameters.
/// </summary>
public Dictionary<string, string> ExtraQueryParameters { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The right place for this is the MSAL provider options, this is not a feature all our implementations offer and not something we plan to do at the moment.

@captainsafia captainsafia added the pr: pending author input For automation. Specifically separate from Needs: Author Feedback label Apr 7, 2021
@ghost
Copy link

ghost commented Apr 24, 2021

Hi @ma3yta.
It seems you haven't touched this PR for the last two weeks. To avoid accumulating old PRs, we're marking it as stale. As a result, it will be closed if no further activity occurs within 4 days of this comment. You can learn more about our Issue Management Policies here.

@ghost ghost added the stale Indicates a stale issue. These issues will be closed automatically soon. label Apr 24, 2021
@ghost ghost closed this Apr 28, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercn javiercn javiercn left review comments

Assignees

@javiercn javiercn

Labels
area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member pr: pending author input For automation. Specifically separate from Needs: Author Feedback stale Indicates a stale issue. These issues will be closed automatically soon.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ma3yta @dnfadmin @Pilchie @javiercn @captainsafia