Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching Redis: Add option to register profiling session #31018

Merged
merged 4 commits into from
Mar 20, 2021
Merged

Caching Redis: Add option to register profiling session #31018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1907aa0
Add option to register profiling session
glucaci Mar 18, 2021
4b9b012
Add API change
glucaci Mar 18, 2021
c76a6da
Fix public API declaration
glucaci Mar 18, 2021
1ccd08c
Cleanup
glucaci Mar 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Caching/StackExchangeRedis/src/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
#nullable enable
~Microsoft.Extensions.Caching.StackExchangeRedis.RedisCacheOptions.ProfilingSession.get -> System.Func<StackExchange.Redis.Profiling.ProfilingSession>
~Microsoft.Extensions.Caching.StackExchangeRedis.RedisCacheOptions.ProfilingSession.set -> void
11 changes: 11 additions & 0 deletions src/Caching/StackExchangeRedis/src/RedisCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,8 @@ private void Connect()
{
_connection = ConnectionMultiplexer.Connect(_options.Configuration);
}

TryRegisterProfiler();
_cache = _connection.GetDatabase();
}
}
Expand Down Expand Up @@ -232,6 +234,7 @@ private void Connect()
_connection = await ConnectionMultiplexer.ConnectAsync(_options.Configuration).ConfigureAwait(false);
}

TryRegisterProfiler();
_cache = _connection.GetDatabase();
}
}
Expand All @@ -241,6 +244,14 @@ private void Connect()
}
}

private void TryRegisterProfiler()
{
if (_connection != null && _options.ProfilingSession != null)
{
_connection.RegisterProfiler(_options.ProfilingSession);
}
}

private byte[] GetAndRefresh(string key, bool getData)
{
if (key == null)
Expand Down
9 changes: 8 additions & 1 deletion src/Caching/StackExchangeRedis/src/RedisCacheOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System;
using Microsoft.Extensions.Options;
using StackExchange.Redis;
using StackExchange.Redis.Profiling;

namespace Microsoft.Extensions.Caching.StackExchangeRedis
{
Expand All @@ -28,9 +30,14 @@ public class RedisCacheOptions : IOptions<RedisCacheOptions>
/// </summary>
public string InstanceName { get; set; }

/// <summary>
/// The Redis profiling session
/// </summary>
public Func<ProfilingSession> ProfilingSession { get; set; }

RedisCacheOptions IOptions<RedisCacheOptions>.Value
{
get { return this; }
}
}
}
}