-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up async timeout extension methods V2 #31768
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabling target .net6.0 for AspNetCore Testing project
ladeak
requested review from
BrennanConroy,
halter73,
jkotalik and
Tratcher
as code owners
April 13, 2021 18:03
ghost
added
the
community-contribution
Indicates that the PR has been added by a community member
label
Apr 13, 2021
V1 version: #31671 see for further details and discussions. |
I will close and cancel this PR, and evolve the one referred as v1. |
Hi @ladeak. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
amcasey
added
area-middleware
Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware
area-networking
Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
and removed
area-runtime
labels
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-middleware
Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware
area-networking
Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
area-signalr
Includes: SignalR clients and servers
community-contribution
Indicates that the PR has been added by a community member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidating all Timeout extension methods in Shared folder
Adding a new compiler condition to set namespace and visibility of the TaskExtensions to distinguish http2cat and Microsoft.AspNetCore.Testing usage. Both projects reference the Shared file.
http2cat uses namespace
System.Threading.Tasks.Extensions
so that the catch block in TimeoutAfter method can filter catching TimeoutException based on the Source property.Functional/Integration tests add file reference to Shared TaskExtensions (as they do for http2cat as well) to make http2cat\Http2Utilities.cs compile without referencing Microsoft.AspNetCore.Testing
Removing WithTimeout, OrTimeout and DefaultTimeout definitions in other projects
Using DefaultTimeout consistently instead of WithTimeout and OrTimeout
Keeping Timeout duration definitions unique to projects (IIS) which has larger than the usual 30 seconds elsewhere
Adding NETCore TargetFramwork to Microsoft.AspNetCore.Testing so .NET6 bits can be used
Using WaitAsync in NET6 and with if-else compiler switches to fallback to existing implementation
Addresses #16620