-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal hosting #31825
Minimal hosting #31825
Conversation
dd8bd1f
to
15757e6
Compare
3e827dc
to
c788f3b
Compare
@Pilchie This is up for API review Monday, but we really want this in preview4. Should we try to merge this today (pending approvals ofc), or wait for API review? |
We can retarget it to the Preview 4 branch and still merge on Monday after API review. |
5d77e9e
to
eb4ef57
Compare
d114d77
to
1935f76
Compare
1935f76
to
b430995
Compare
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
FYI, working to unblock the code check with #31982 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Let's move forward so we can get in the hands of the customers for feedback.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
We're looking to collect feedback on our new "minimal hosting" API which we will present at BUILD. This adds quite a few types like
WebApplication
andWebApplicationBuilder
as minimal alternative toHost
andWebHost
.We are also planning to update the
dotnet new empty
/dotnet new web
template for preview4 to use the newWebApplication
type.For this preview only, this does add temporarily a new
Configuration : IConfigurationRoot, IConfigurationBuilder
type to theMicrosoft.AspNetCore.Builder
namespace. I plan to submit a proper API proposal for to introduce this type to theMicrosoft.Extensions.Configuration
shortly.Customer Impact
This is entirely new API, so the only impact is giving customers an early preview version of this new minimal hosting API to try out. It does not change any of the existing Hosts so there's no impact to existing apps.
Regression?
Risk
This change merely adds new API to an existing
Microsoft.AspNetCore
assembly.Verification
Packaging changes reviewed?
Addresses #30354
See https://github.com/featherhttp/framework to see the original versions of all of the newly added types.
The new
Configuration
type should be in Microsoft.Extensions as noted in the issue. I plan to open an API proposal to do this tomorrow. I think we'll leave it in the ASP.NET Core shared runtime temporarily for preview4.