Clear caches from more places on a hot reload event #32509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavkm
force-pushed
the
prkrishn/more-cache
branch
from
4f6029f
to
067f5b5
Compare
|
FYI @tommcdon \ @mikem8361 |
javiercn
approved these changes
May 10, 2021
I like this. It's less likely we would add a new cache in the future and forget to clear it up if we do this. |
src/JSInterop/Microsoft.JSInterop/src/Infrastructure/DotNetDispatcher.cs
Show resolved
Hide resolved
SteveSandersonMS
approved these changes
May 11, 2021
|
(Deleted comment posted on the wrong PR) |
|
While centralizing the caches sounds nice on paper, it's a bit difficult. The caches are on a mix of instance and static types which makes the cache lifetime hard to pin down. Additionally, they're also split across several assemblies that do not have IVT access to each other. We definitely don't want to introduce public APIs for caches. I'm going to punt on doing that for now. MVC might be a bit more open to this option since all of it's caches are non-static. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.