Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContentResult IResult Implementation Improvement #32735

Merged
merged 1 commit into from
May 17, 2021
Merged

ContentResult IResult Implementation Improvement #32735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions src/Mvc/Mvc.Core/src/ContentResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,17 +82,7 @@ async Task IResult.ExecuteAsync(HttpContext httpContext)
if (Content != null)
{
response.ContentLength = resolvedContentTypeEncoding.GetByteCount(Content);

await using (var textWriter = new HttpResponseStreamWriter(response.Body, resolvedContentTypeEncoding))
{
await textWriter.WriteAsync(Content);

// Flushing the HttpResponseStreamWriter does not flush the underlying stream. This just flushes
// the buffered text in the writer.
// We do this rather than letting dispose handle it because dispose would call Write and we want
// to call WriteAsync.
await textWriter.FlushAsync();
}
await response.WriteAsync(Content, resolvedContentTypeEncoding);
}
}
}
Expand Down