Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Blazor Server Project Template #42079

Merged
merged 38 commits into from
Jun 22, 2022

Conversation

cerasamson
Copy link
Contributor

Empty Blazor Server Project Template

Created an empty Blazor server template from the existing one. All contents in the Data folder were removed, along with additional HTML/CSS formatting. Authentication is removed entirely.

Screenshot of template:

image

Fixes #32832

@cerasamson cerasamson added area-blazor Includes: Blazor, Razor Components feature-templates labels Jun 7, 2022
@cerasamson cerasamson added this to the 7.0-preview6 milestone Jun 7, 2022
@cerasamson cerasamson requested a review from a team June 7, 2022 17:51
@cerasamson cerasamson requested a review from Pilchie as a code owner June 7, 2022 17:51
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 7, 2022
@TanayParikh
Copy link
Contributor

TanayParikh commented Jun 7, 2022

Screen Shot 2022-06-07 at 12 09 55 PM

Does anyone know if we need to do something special for VS4Mac to pickup this new template? @mrward?

@Eilon
Copy link
Member

Eilon commented Jun 7, 2022

Some questions:

  1. Is there any "list of all the templates" that this needs to be added to, or is it magically included in the build and will be included in VS?
  2. Will this template be included in whatever test(s) we have for templates, to make sure they get created and compile/run correctly? (Again, this might be magical and automatic, but I don't know.)

@mrward
Copy link
Contributor

mrward commented Jun 7, 2022

@TanayParikh - VS Mac will need a change to show this project template. Will this only be in the .NET 7 SDK templates and not backported to the .NET 6 SDK?

@TanayParikh
Copy link
Contributor

TanayParikh commented Jun 7, 2022

Will this only be in the .NET 7 SDK templates and not backported to the .NET 6 SDK?

That's correct. Note, we'll also be adding another empty Blazor WASM template in addition to this empty Blazor Server template.

@TanayParikh
Copy link
Contributor

Is there any "list of all the templates" that this needs to be added to, or is it magically included in the build and will be included in VS?

From my understanding the current changeset should be sufficient. @cerasamson verified this new template shows up with dotnet new --list as well as the VS new project UI.

Will this template be included in whatever test(s) we have for templates, to make sure they get created and compile/run correctly? (Again, this might be magical and automatic, but I don't know.)

We'll need to update/add the test for coverage in this area (at the very least update the test which validates the appropriate files show up with dotnet new blazorserverempty).

cerasamson and others added 2 commits June 8, 2022 10:07
…erverWeb-CSharp/wwwroot/css/site.css

Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com>
@TanayParikh TanayParikh requested a review from a team June 8, 2022 17:16
cerasamson and others added 2 commits June 8, 2022 16:06
…erverWeb-CSharp/Program.cs

Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com>
Copy link
Contributor

@TanayParikh TanayParikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment. Other than that, this looks great and ready for merging 😄

Copy link
Contributor

@TanayParikh TanayParikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, 🚢 it! 🎉

@cerasamson cerasamson requested a review from phenning June 21, 2022 21:01
Copy link
Contributor

@phenning phenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cerasamson cerasamson merged commit 8546f1e into dotnet:main Jun 22, 2022
@TanayParikh
Copy link
Contributor

🎉 👏 🥇

@cerasamson cerasamson deleted the t-samsoncera/empty_template branch June 22, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty Blazor project template
5 participants