Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-preview6] Backport custom HTML elements rendering Blazor components #42383

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

MackinnonBuck
Copy link
Member

@MackinnonBuck MackinnonBuck commented Jun 23, 2022

Custom HTML elements rendering Blazor components

This PR productizes the custom elements support package. Backport of #42314

Description

This package provides a simple mechanism for using Blazor components as custom elements. This means you can easily render Blazor components dynamically from other SPA frameworks, such as Angular or React.

Fixes #38447

Customer Impact

This package brings value to the scenario where Blazor components are gradually introduced into existing projects written in other SPA frameworks. Rather than having to manually manage the state and lifecycle of Blazor root components using JavaScript APIs, it can now be done in a more intuitive fashion using custom HTML elements. By making this package official and built with the rest of the repository, customers can trust that it will be stable and up to date with the latest version of Blazor.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

These changes do not touch the core framework. The new code remains almost unchanged from the existing support package, so it's unlikely we're introducing new bugs.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@MackinnonBuck MackinnonBuck requested review from a team, dougbu, wtgodbe and Pilchie as code owners June 23, 2022 21:51
@MackinnonBuck MackinnonBuck added Servicing-approved Shiproom has approved the issue area-blazor Includes: Blazor, Razor Components labels Jun 23, 2022
@dougbu
Copy link
Member

dougbu commented Jun 24, 2022

@MackinnonBuck I can approve and merge this but need your confirmation that (other than whitespace) this change is identical to what was merged earlier today into 'main' (8942608). Please let me know. If there are a few differences, please point them out&helllip;

@MackinnonBuck
Copy link
Member Author

@dougbu This change is identical to the one merged into main earlier today.

@dougbu dougbu enabled auto-merge (squash) June 24, 2022 00:18
@dougbu
Copy link
Member

dougbu commented Jun 24, 2022

I didn't see anything suspicious in the CI failure and am rerunning failed jobs there. Enabled auto-merge here.

@MackinnonBuck
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dougbu
Copy link
Member

dougbu commented Jun 27, 2022

@MackinnonBuck please merge #42459 into this. I didn't realize the two PRs were tightly bound.

/cc @mmitche

@dougbu dougbu merged commit be4c603 into release/7.0-preview6 Jun 28, 2022
@dougbu dougbu deleted the mbuck/backport-custom-elements branch June 28, 2022 01:43
@mkArtakMSFT mkArtakMSFT added this to the 7.0-preview6 milestone Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants