Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quarantine EnableCoreHostTraceLogging_FileCaptureNativeLogs #42821

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Quarantine EnableCoreHostTraceLogging_FileCaptureNativeLogs #42821

merged 2 commits into from
Jul 20, 2022

Conversation

halter73
Copy link
Member

@ghost ghost added the area-runtime label Jul 19, 2022
@halter73 halter73 requested a review from dougbu July 19, 2022 19:43
@halter73
Quarantine instead of skip.
955288d 
- Test failure is inconsistent on Windows.11.Amd64.Client.Open queue
@halter73 halter73 changed the title Skip EnableCoreHostTraceLogging_FileCaptureNativeLogs on Windows.11.Amd64.Client.Open Helix queue Quarantine EnableCoreHostTraceLogging_FileCaptureNativeLogs Jul 19, 2022
@halter73
Copy link
Member Author

I updated this to quarantine the test instead of skip the test on Windows.11.Amd64.Client.Open Helix queue because the failures went away. I thought it was a more consistent issue with that queue at first.

@halter73 halter73 merged commit 0602a32 into main Jul 20, 2022
@halter73 halter73 deleted the halter73/42820 branch July 20, 2022 02:31
@ghost ghost added this to the 7.0-rc1 milestone Jul 20, 2022
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
7.0-rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@halter73 @dougbu @amcasey