Strip Content-Length: 0 from responses that should not have a Content-Length #43417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityamandaleeka
requested review from
Tratcher,
halter73,
BrennanConroy and
JamesNK
as code owners
ghost
added
the
JamesNK
reviewed
Aug 20, 2022
JamesNK
approved these changes
Aug 20, 2022
Tratcher
approved these changes
Aug 22, 2022
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We made a change (earlier in RC1, #43103) that tightened up Kestrel's Content-Length handling. Part of the change made it so that we throw if a
Content-Lengthis set on responses that shouldn't have aContent-Length(1xx, 204 responses, or any 2xx responses to a CONNECT request).This change keeps that behavior for nonzero values of
Content-Length. If theContent-Lengthis present but it's zero, we will now just remove it instead of throwing, since its absence is semantically equivalent.We keep the existing behavior for 205's (the spec allows Content-Length 0 for those explicitly).
This is the remainder of the RC1 fix for #43316