Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MessagePack-CSharp #43474

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Update MessagePack-CSharp #43474

merged 1 commit into from
Aug 23, 2022

Conversation

TanayParikh
Copy link
Contributor

6caf2996c82d2b91528fad41e9c78e09770e73d4 -> fe9fa0834d18492eb229ff2923024af2c87553f8

aspnet/MessagePack-CSharp#2

@TanayParikh
Update MessagePack-CSharp
70f00bd 
6caf2996c82d2b91528fad41e9c78e09770e73d4 -> fe9fa0834d18492eb229ff2923024af2c87553f8

aspnet/MessagePack-CSharp#2
@TanayParikh TanayParikh requested a review from a team August 22, 2022 21:19
@TanayParikh TanayParikh requested review from a team, dougbu and wtgodbe as code owners August 22, 2022 21:19
@TanayParikh TanayParikh enabled auto-merge (squash) August 22, 2022 21:20
dougbu
dougbu approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but I suggest backporting at least to release/7.0 (for RC2), if not release/7.0-rc1

@TanayParikh TanayParikh mentioned this pull request Aug 22, 2022
Closed
@TanayParikh
Copy link
Contributor Author

TanayParikh commented Aug 22, 2022 •
edited
Loading

if not release/7.0-rc1

#43475.

On second thought let's maybe do RC2 (release/7.0). This is completed untested, and I don't want to push that into RC1 at this point.

TanayParikh added a commit that referenced this pull request Aug 22, 2022
@TanayParikh
Update MessagePack-CSharp
0fb4e24 
6caf2996c82d2b91528fad41e9c78e09770e73d4 -> fe9fa0834d18492eb229ff2923024af2c87553f8

aspnet/MessagePack-CSharp#2

Backport #43474
@TanayParikh TanayParikh mentioned this pull request Aug 22, 2022
Merged
@TanayParikh
Copy link
Contributor Author

#43476

wtgodbe pushed a commit that referenced this pull request Aug 23, 2022
@TanayParikh
Update MessagePack-CSharp (#43476)
797aed7 
6caf2996c82d2b91528fad41e9c78e09770e73d4 -> fe9fa0834d18492eb229ff2923024af2c87553f8

aspnet/MessagePack-CSharp#2

Backport #43474
@TanayParikh TanayParikh merged commit f1353bd into main Aug 23, 2022
@TanayParikh TanayParikh deleted the taparik/messagepackUpdate branch August 23, 2022 17:30
@ghost ghost added this to the 8.0-alpha1 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0-preview1
Development

Successfully merging this pull request may close these issues.
2 participants
@TanayParikh @dougbu