source-build: don't use crossgen when building for mono runtime. #44842
Conversation
ghost
added
area-infrastructure
|
Thanks for your PR, @tmds. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
| @@ -55,6 +55,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <InnerBuildArgs>$(InnerBuildArgs) /p:SourceBuildRuntimeIdentifier=$(TargetRuntimeIdentifier)</InnerBuildArgs> | |||
| <InnerBuildArgs Condition="'$(SourceBuildUseMonoRuntime)' == 'true'">$(InnerBuildArgs) /p:CrossgenOutput=false</InnerBuildArgs> | |||
There was a problem hiding this comment.
What will set $(SourceBuildUseMonoRuntime)❔ I don't see it in Arcade, at least the commit I've got locally
There was a problem hiding this comment.
Could we use regular crossgen?
I don't know. Maybe mono doesn't support R2R assemblies? I'm just guessing.
Disabling this is what we're doing on the mono specific architectures already:
What will set $(SourceBuildUseMonoRuntime)grey_question I don't see it in Arcade, at least the commit I've got locally
It gets set by installer, see dotnet/installer#14792.
|
@dougbu yes, please merge this, and also backport it to 7.0. |
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/aspnetcore/actions/runs/3430825633 |
dotnet/installer#14792 enables building .NET from source with mono runtime instead of coreclr for 'any' architecture.
With mono runtime, crossgen2 is not available so we mustn't use it while building aspnetcore.
@dougbu ptal.
cc @MichaelSimons @crummel