Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove now-redundant properties from AOT template #46194

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Remove now-redundant properties from AOT template #46194

merged 2 commits into from
Jan 20, 2023

Conversation

halter73
Copy link
Member

This is a reaction to dotnet/sdk#29984 which makes TrimMode and PublishIISAssets default to "full" and "false" respectively when PublishAot is "true".

@halter73 halter73 requested review from a team, dougbu and wtgodbe as code owners January 20, 2023 20:49
eerhardt
eerhardt approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@halter73 halter73 enabled auto-merge (squash) January 20, 2023 21:46
@build-analysis build-analysis bot mentioned this pull request Jan 20, 2023
Open
5 tasks
@halter73 halter73 merged commit 9a79370 into main Jan 20, 2023
@halter73 halter73 deleted the halter73/smaller-aot-csproj branch January 20, 2023 22:40
@ghost ghost added this to the 8.0-preview1 milestone Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@DamianEdwards DamianEdwards Awaiting requested review from DamianEdwards

@dougbu dougbu Awaiting requested review from dougbu

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0-preview1
Development

Successfully merging this pull request may close these issues.
2 participants
@halter73 @eerhardt