Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete duplicate define #46202

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Delete duplicate define #46202

merged 1 commit into from
Jan 23, 2023

Conversation

Suchiman
Copy link
Contributor

The exact same thing exists 2 lines above that

@Suchiman
Delete duplicate define
cf00d6c 
The exact same thing exists 2 lines above that
@ghost ghost added area-runtime community-contribution Indicates that the PR has been added by a community member labels Jan 21, 2023
@ghost
Copy link

ghost commented Jan 21, 2023

Thanks for your PR, @Suchiman. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@build-analysis build-analysis bot mentioned this pull request Jan 22, 2023
Open
5 tasks
mkArtakMSFT
mkArtakMSFT approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this, @Suchiman.

@mkArtakMSFT mkArtakMSFT merged commit ac52b4d into dotnet:main Jan 23, 2023
@ghost ghost added this to the 8.0-preview1 milestone Jan 23, 2023
@Suchiman Suchiman deleted the patch-1 branch January 23, 2023 17:05
atossell91 pushed a commit to atossell91/aspnetcore that referenced this pull request Jan 23, 2023
@Suchiman @atossell91
Delete duplicate define (dotnet#46202)
c404570 
The exact same thing exists 2 lines above that
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkArtakMSFT mkArtakMSFT mkArtakMSFT approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

@mgravell mgravell Awaiting requested review from mgravell mgravell is a code owner

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
8.0-preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@Suchiman @mkArtakMSFT @amcasey