Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Named Pipe] Check for pipe broken on WaitConnectionAsync #46230

Merged
merged 1 commit into from
Jan 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,15 @@ private async Task StartAsync(NamedPipeServerStream nextStream)
}
}
}
catch (IOException ex) when (!_listeningToken.IsCancellationRequested)
{
// WaitForConnectionAsync can throw IOException when the pipe is broken.
NamedPipeLog.ConnectionListenerBrokenPipe(_log, ex);

// Dispose existing pipe, create a new one and continue accepting.
nextStream.Dispose();
nextStream = CreateServerStream();
}
catch (OperationCanceledException ex) when (_listeningToken.IsCancellationRequested)
{
// Cancelled the current token
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,4 +77,6 @@ public static void ConnectionDisconnect(ILogger logger, NamedPipeConnection conn
}
}

[LoggerMessage(8, LogLevel.Debug, "Named pipe listener received broken pipe while waiting for a connection.", EventName = "ConnectionListenerBrokenPipe")]
public static partial void ConnectionListenerBrokenPipe(ILogger logger, Exception ex);
}