Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update branding to 6.0.16 #47076

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Update branding to 6.0.16 #47076

merged 2 commits into from
Mar 7, 2023

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Mar 7, 2023

No description provided.

@wtgodbe wtgodbe requested a review from dougbu as a code owner March 7, 2023 18:10
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 7, 2023
@ghost ghost added this to the 6.0.x milestone Mar 7, 2023
@ghost
Copy link

ghost commented Mar 7, 2023

Hi @wtgodbe. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@wtgodbe wtgodbe enabled auto-merge (squash) March 7, 2023 18:28
@eerhardt
Copy link
Member

eerhardt commented Mar 7, 2023

The failure looks like the same as #45811, which was quarantined for a while. It also had a backport to release/7.0 in #46251.

2023-03-07T19:05:01.5717546Z [xUnit.net 00:00:05.84]       System.Net.Http.HttpRequestException : The HTTP request headers length exceeded the server limit of 32768 bytes.
2023-03-07T19:05:01.5780454Z [xUnit.net 00:00:05.84]       Stack Trace:
2023-03-07T19:05:01.5804016Z [xUnit.net 00:00:05.83]     Interop.FunctionalTests.HttpClientHttp2InteropTests.Settings_MaxHeaderListSize_Server(scheme: "http") [FAIL]
2023-03-07T19:05:01.5820544Z [xUnit.net 00:00:05.85]            at System.Net.Http.Http2Connection.WriteHeaders(HttpRequestMessage request, ArrayBuffer& headerBuffer)
2023-03-07T19:05:01.5844021Z [xUnit.net 00:00:05.85]            at System.Net.Http.Http2Connection.SendHeadersAsync(HttpRequestMessage request, CancellationToken cancellationToken, Boolean mustFlush)
2023-03-07T19:05:01.5866319Z [xUnit.net 00:00:05.85]            at System.Net.Http.Http2Connection.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
2023-03-07T19:05:01.5913808Z [xUnit.net 00:00:05.85]            at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
2023-03-07T19:05:01.5928330Z [xUnit.net 00:00:05.85]            at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
2023-03-07T19:05:01.5943369Z [xUnit.net 00:00:05.85]            at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
2023-03-07T19:05:01.5958079Z [xUnit.net 00:00:05.86]         /_/src/Shared/TaskExtensions.cs(108,0): at Microsoft.AspNetCore.Testing.TaskExtensions.TimeoutAfter[T](Task`1 task, TimeSpan timeout, String filePath, Int32 lineNumber)
2023-03-07T19:05:01.5976991Z [xUnit.net 00:00:05.86]         /_/src/Servers/Kestrel/test/Interop.FunctionalTests/HttpClientHttp2InteropTests.cs(1369,0): at Interop.FunctionalTests.HttpClientHttp2InteropTests.Settings_MaxHeaderListSize_Server(String scheme)
2023-03-07T19:05:01.5999818Z [xUnit.net 00:00:05.86]         --- End of stack trace from previous location ---
2023-03-07T19:05:01.6029062Z [xUnit.net 00:00:05.87]       Output:
2023-03-07T19:05:01.6050349Z [xUnit.net 00:00:05.87]         | [0.005s] TestLifetime Information: Starting test Settings_MaxHeaderListSize_Server-http at 2023-03-07T19:05:01
2023-03-07T19:05:01.6089744Z [xUnit.net 00:00:05.87]         | [0.005s] Microsoft.Extensions.Hosting.Internal.Host Debug: Hosting starting
2023-03-07T19:05:01.6113435Z [xUnit.net 00:00:05.88]         | [0.006s] Microsoft.Hosting.Lifetime Information: Now listening on: http://127.0.0.1:38161
2023-03-07T19:05:01.6142450Z [xUnit.net 00:00:05.88]         | [0.006s] Microsoft.AspNetCore.Hosting.Diagnostics Debug: Loaded hosting startup assembly Interop.FunctionalTests
2023-03-07T19:05:01.6165582Z [xUnit.net 00:00:05.88]         | [0.006s] Microsoft.Hosting.Lifetime Information: Application started. Press Ctrl+C to shut down.
2023-03-07T19:05:01.6187450Z [xUnit.net 00:00:05.88]         | [0.006s] Microsoft.Hosting.Lifetime Information: Hosting environment: Production
2023-03-07T19:05:01.6208759Z [xUnit.net 00:00:05.89]         | [0.006s] Microsoft.Hosting.Lifetime Information: Content root path: /datadisks/disk1/work/B5980925/w/BBCB09E7/e/
2023-03-07T19:05:01.6289239Z [xUnit.net 00:00:05.89]         | [0.006s] Microsoft.Extensions.Hosting.Internal.Host Debug: Hosting started
2023-03-07T19:05:01.6319898Z [xUnit.net 00:00:05.89]         | [0.007s] Microsoft.AspNetCore.Server.Kestrel.Connections Debug: Connection id "0HMOV7RBR9L9P" accepted.
2023-03-07T19:05:01.6357156Z [xUnit.net 00:00:05.89]         | [0.007s] Microsoft.AspNetCore.Server.Kestrel.Connections Debug: Connection id "0HMOV7RBR9L9P" started.
2023-03-07T19:05:01.6388601Z [xUnit.net 00:00:05.90]         | [0.007s] Microsoft.AspNetCore.Server.Kestrel.Http2 Trace: Connection id "0HMOV7RBR9L9P" sending SETTINGS frame for stream ID 0 with length 18 and flags NONE.
2023-03-07T19:05:01.6415606Z [xUnit.net 00:00:05.90]         | [0.007s] Microsoft.AspNetCore.Server.Kestrel.Http2 Trace: Connection id "0HMOV7RBR9L9P" sending WINDOW_UPDATE frame for stream ID 0 with length 4 and flags 0x0.
2023-03-07T19:05:01.6502440Z [xUnit.net 00:00:05.90]         | [0.007s] Microsoft.AspNetCore.Server.Kestrel.Http2 Trace: Connection id "0HMOV7RBR9L9P" received SETTINGS frame for stream ID 0 with length 12 and flags NONE.
2023-03-07T19:05:01.6525379Z [xUnit.net 00:00:05.90]         | [0.007s] Microsoft.AspNetCore.Server.Kestrel.Http2 Trace: Connection id "0HMOV7RBR9L9P" sending SETTINGS frame for stream ID 0 with length 0 and flags ACK.
2023-03-07T19:05:01.6540766Z [xUnit.net 00:00:05.90]         | [0.007s] Microsoft.AspNetCore.Server.Kestrel.Http2 Trace: Connection id "0HMOV7RBR9L9P" received WINDOW_UPDATE frame for stream ID 0 with length 4 and flags 0x0.
2023-03-07T19:05:01.6556379Z [xUnit.net 00:00:05.90]         | [0.007s] Microsoft.AspNetCore.Server.Kestrel.Http2 Trace: Connection id "0HMOV7RBR9L9P" received SETTINGS frame for stream ID 0 with length 0 and flags ACK.
2023-03-07T19:05:01.6571433Z [xUnit.net 00:00:05.90]         | [0.009s] Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets Debug: Connection id "0HMOV7RBR9L9P" received FIN.
2023-03-07T19:05:01.6586307Z [xUnit.net 00:00:05.91]         | [0.009s] Microsoft.AspNetCore.Server.Kestrel.Http2 Debug: Connection id "0HMOV7RBR9L9P" is closed. The last processed stream ID was 0.
2023-03-07T19:05:01.6601355Z [xUnit.net 00:00:05.91]         | [0.009s] Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets Debug: Connection id "0HMOV7RBR9L9P" sending FIN because: "The client closed the connection."
2023-03-07T19:05:01.6616353Z [xUnit.net 00:00:05.91]         | [0.010s] Microsoft.AspNetCore.Server.Kestrel.Connections Debug: Connection id "0HMOV7RBR9L9P" stopped.
2023-03-07T19:05:01.6633369Z [xUnit.net 00:00:05.91]         | [0.011s] Interop.FunctionalTests.HttpClientHttp2InteropTests Error: Test threw an exception.
2023-03-07T19:05:01.6648309Z [xUnit.net 00:00:05.91]         | System.Net.Http.HttpRequestException: The HTTP request headers length exceeded the server limit of 32768 bytes.
2023-03-07T19:05:01.6664105Z [xUnit.net 00:00:05.91]         |    at System.Net.Http.Http2Connection.WriteHeaders(HttpRequestMessage request, ArrayBuffer& headerBuffer)
2023-03-07T19:05:01.6678827Z [xUnit.net 00:00:05.91]         |    at System.Net.Http.Http2Connection.SendHeadersAsync(HttpRequestMessage request, CancellationToken cancellationToken, Boolean mustFlush)
2023-03-07T19:05:01.6693827Z [xUnit.net 00:00:05.91]         |    at System.Net.Http.Http2Connection.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
2023-03-07T19:05:01.6712635Z [xUnit.net 00:00:05.91]         |    at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
2023-03-07T19:05:01.6727237Z [xUnit.net 00:00:05.91]         |    at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
2023-03-07T19:05:01.6742276Z [xUnit.net 00:00:05.91]         |    at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
2023-03-07T19:05:01.6762520Z [xUnit.net 00:00:05.91]         |    at Microsoft.AspNetCore.Testing.TaskExtensions.TimeoutAfter[T](Task`1 task, TimeSpan timeout, String filePath, Int32 lineNumber) in /_/src/Shared/TaskExtensions.cs:line 108
2023-03-07T19:05:01.6795224Z [xUnit.net 00:00:05.91]         |    at Interop.FunctionalTests.HttpClientHttp2InteropTests.Settings_MaxHeaderListSize_Server(String scheme) in /_/src/Servers/Kestrel/test/Interop.FunctionalTests/HttpClientHttp2InteropTests.cs:line 1369
2023-03-07T19:05:01.6811469Z [xUnit.net 00:00:05.91]         |    at Xunit.Sdk.TestInvoker`1.<>c__DisplayClass48_1.<<InvokeTestMethodAsync>b__1>d.MoveNext() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\Runners\TestInvoker.cs:line 264
2023-03-07T19:05:01.6827309Z [xUnit.net 00:00:05.91]         | --- End of stack trace from previous location ---
2023-03-07T19:05:01.6841720Z [xUnit.net 00:00:05.91]         |    at Xunit.Sdk.ExecutionTimer.AggregateAsync(Func`1 asyncAction) in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\ExecutionTimer.cs:line 48
2023-03-07T19:05:01.6856756Z [xUnit.net 00:00:05.91]         |    at Xunit.Sdk.ExceptionAggregator.RunAsync(Func`1 code) in C:\Dev\xunit\xunit\src\xunit.core\Sdk\ExceptionAggregator.cs:line 96
2023-03-07T19:05:01.6872503Z [xUnit.net 00:00:05.91]         | [0.013s] TestLifetime Information: Finished test Settings_MaxHeaderListSize_Server-http in 0.0087028s

This is in the release/6.0 branch. Should we make a similar backport to release/6.0?

@wtgodbe
Copy link
Member Author

wtgodbe commented Mar 7, 2023

This is in the release/6.0 branch. Should we make a similar backport to release/6.0?

Looks like it's already been fixed in the internal branch, but that won't make it into the public branch until next week. I'll cherry pick it here to speed things up.

@wtgodbe wtgodbe merged commit 457fbd6 into dotnet:release/6.0 Mar 7, 2023
@ghost ghost removed this from the 6.0.x milestone Mar 7, 2023
@wtgodbe wtgodbe deleted the branding-6.0.16-2023-03-07-1008 branch March 7, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants