Update RDG to use interceptors feature #48555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
captainsafia
added
feature-rdg
area-minimal
davidfowl
reviewed
Jun 1, 2023
src/Http/Http.Extensions/gen/StaticRouteHandler/Model/Endpoint.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jun 2, 2023
...tDelegateGenerator/Baselines/MapAction_ExplicitHeader_NullableStringArrayParam.generated.txt
Outdated
Show resolved
Hide resolved
captainsafia
force-pushed
the
safia/interceptors-prototype
branch
from
709c0d8
to
3c020e2
Compare
captainsafia
force-pushed
the
safia/interceptors-prototype
branch
from
b84d1b9
to
983fdb4
Compare
captainsafia
force-pushed
the
safia/interceptors-prototype
branch
5 times, most recently
from
16e9213
to
d72d26f
Compare
captainsafia
force-pushed
the
safia/interceptors-prototype
branch
from
d72d26f
to
c528e8f
Compare
eerhardt
reviewed
Jun 14, 2023
Comment on lines
+30
to
+31
| [System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessage("AOT", "IL3050", Justification = "This implementation invokes uses compile-time code gen to construct the RequestDelegate.")] | ||
| [System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessage("Trimming", "IL2026", Justification = "This implementation invokes uses compile-time code gen to construct the RequestDelegate.")] |
There was a problem hiding this comment.
I don't understand why we are getting these warnings. Can you explain?
eerhardt
reviewed
Jun 14, 2023
| @@ -9,8 +9,8 @@ | |||
| using Microsoft.AspNetCore.App.Analyzers.Infrastructure; | |||
| using Microsoft.CodeAnalysis; | |||
| using Microsoft.CodeAnalysis.Operations; | |||
| using Microsoft.AspNetCore.Http.RequestDelegateGenerator.StaticRouteHandlerModel.Emitters; | |||
| using Microsoft.AspNetCore.Http.RequestDelegateGenerator.StaticRouteHandlerModel; | |||
| using Microsoft.AspNetCore.Http.RequestDelegateGenerator.StaticRouteHandler.Emitters; | |||
There was a problem hiding this comment.
It might help out doing the review if this refactoring was separated into its own PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #48289