Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant SourceBuildTrimNetFrameworkTargets property #49022

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Remove redundant SourceBuildTrimNetFrameworkTargets property #49022

merged 1 commit into from
Jul 7, 2023

Conversation

v-chayan
Copy link
Contributor

@v-chayan v-chayan requested a review from a team as a code owner June 26, 2023 06:32
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 26, 2023
@v-chayan v-chayan mentioned this pull request Jun 26, 2023
Closed
@ghost
Copy link

ghost commented Jul 7, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please leave an /azp run comment here to rerun the CI pipeline and confirm success before merging the change.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jul 7, 2023
@NikolaMilosavljevic NikolaMilosavljevic merged commit 27a3350 into dotnet:main Jul 7, 2023
@ghost ghost added this to the 8.0-preview7 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolaMilosavljevic NikolaMilosavljevic NikolaMilosavljevic approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Milestone
8.0-preview7
Development

Successfully merging this pull request may close these issues.
2 participants
@v-chayan @NikolaMilosavljevic