Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename hosting, routing and error handling metrics to be consistent with OpenTelemetry #49743

Merged
merged 13 commits into from
Aug 5, 2023
Merged

Rename hosting, routing and error handling metrics to be consistent with OpenTelemetry #49743

merged 13 commits into from
Aug 5, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jul 31, 2023

@ghost ghost added the area-hosting Includes Hosting label Jul 31, 2023
@JamesNK JamesNK requested a review from BrennanConroy as a code owner July 31, 2023 06:58
@JamesNK JamesNK changed the title Rename hosting metrics to be consistent with OpenTelemetry Rename hosting and error handling metrics to be consistent with OpenTelemetry Jul 31, 2023
@JamesNK JamesNK requested a review from javiercn as a code owner July 31, 2023 12:45
@JamesNK JamesNK changed the title Rename hosting and error handling metrics to be consistent with OpenTelemetry Rename hosting, routing and error handling metrics to be consistent with OpenTelemetry Jul 31, 2023
@JamesNK JamesNK force-pushed the jamesnk/rename-hosting-metrics branch from aceacd7 to 8e2a093 Compare August 4, 2023 05:11
@JamesNK JamesNK requested a review from a team as a code owner August 4, 2023 05:11
@JamesNK JamesNK force-pushed the jamesnk/rename-hosting-metrics branch from 8e2a093 to 11298ff Compare August 4, 2023 05:17
noahfalk
noahfalk approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked good other than those same unit strings

src/Hosting/Hosting/src/Internal/HostingMetrics.cs Show resolved Hide resolved
src/Http/Routing/src/RoutingMetrics.cs Show resolved Hide resolved
src/Middleware/Diagnostics/src/DiagnosticsMetrics.cs Outdated Show resolved Hide resolved
@JamesNK JamesNK force-pushed the jamesnk/rename-hosting-metrics branch from f3351db to 7bcb729 Compare August 5, 2023 04:46
@JamesNK JamesNK merged commit ec3722f into main Aug 5, 2023
@JamesNK JamesNK deleted the jamesnk/rename-hosting-metrics branch August 5, 2023 10:12
@ghost ghost added this to the 8.0-rc1 milestone Aug 5, 2023
@eerhardt eerhardt mentioned this pull request Aug 22, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmolkova lmolkova lmolkova left review comments

@noahfalk noahfalk noahfalk approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@javiercn javiercn Awaiting requested review from javiercn javiercn is a code owner

Assignees
No one assigned
Labels
area-hosting Includes Hosting
Projects
None yet
Milestone
8.0-rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@JamesNK @lmolkova @noahfalk