Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SDK to 23523.1 #51588

Merged
merged 6 commits into from
Oct 26, 2023
Merged

Update SDK to 23523.1 #51588

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b2aa80c
Update SDK to 23523.1
amcasey Oct 23, 2023
5d1f927
Update global.json
wtgodbe Oct 24, 2023
b468e82
Fix SignalR await warning
JamesNK Oct 25, 2023
533a66c
Suppress DotNetDispatcher warning with pragma
JamesNK Oct 25, 2023
7895429
Re-add XML suppression
JamesNK Oct 26, 2023
211f0e2
Update src/JSInterop/Microsoft.JSInterop/src/Infrastructure/DotNetDis…
JamesNK Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"sdk": {
"version": "9.0.100-alpha.1.23504.14"
"version": "9.0.100-alpha.1.23524.8"
},
"tools": {
"dotnet": "9.0.100-alpha.1.23504.14",
"dotnet": "9.0.100-alpha.1.23524.8",
"runtimes": {
"dotnet/x86": [
"$(MicrosoftNETCoreBrowserDebugHostTransportVersion)"
Expand Down
5 changes: 5 additions & 0 deletions src/JSInterop/Microsoft.JSInterop/src/Infrastructure/DotNetDispatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,12 @@ private static Task GetTaskByType(Type type, object obj)
private static (MethodInfo methodInfo, Type[] parameterTypes) GetCachedMethodInfo(IDotNetObjectReference objectReference, string methodIdentifier)
{
var type = objectReference.Value.GetType();

// Suppressed with "pragma warning disable" instead of WarningSuppressions.xml so ILLink Roslyn Anayzer doesn't report the warning.
JamesNK marked this conversation as resolved.
Show resolved Hide resolved
#pragma warning disable IL2111 // Method with parameters or return value with `DynamicallyAccessedMembersAttribute` is accessed via reflection. Trimmer can't guarantee availability of the requirements of the method.
var assemblyMethods = _cachedMethodsByType.GetOrAdd(type, ScanTypeForCallableMethods);
#pragma warning restore IL2111 // Method with parameters or return value with `DynamicallyAccessedMembersAttribute` is accessed via reflection. Trimmer can't guarantee availability of the requirements of the method.

if (assemblyMethods.TryGetValue(methodIdentifier, out var result))
{
return result;
Expand Down
4 changes: 2 additions & 2 deletions src/JSInterop/Microsoft.JSInterop/src/Microsoft.JSInterop.WarningSuppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<linker>
<assembly fullname="Microsoft.JSInterop, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60">
<attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
Expand Down Expand Up @@ -74,4 +74,4 @@
<property name="Target">M:Microsoft.JSInterop.Infrastructure.DotNetDispatcher.GetCachedMethodInfo(Microsoft.JSInterop.Infrastructure.IDotNetObjectReference,System.String)</property>
</attribute>
</assembly>
</linker>
</linker>
2 changes: 1 addition & 1 deletion src/SignalR/clients/csharp/Client.Core/src/HubConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -863,7 +863,7 @@ async Task ReadAsyncEnumerableStream()
{
var streamValues = AsyncEnumerableAdapters.MakeCancelableTypedAsyncEnumerable(stream, tokenSource);

await foreach (var streamValue in streamValues)
await foreach (var streamValue in streamValues.ConfigureAwait(false))
{
await SendWithLock(connectionState, new StreamItemMessage(streamId, streamValue), tokenSource.Token).ConfigureAwait(false);
Log.SendingStreamItem(_logger, streamId);
Expand Down
Loading