Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove InvariantGlobalization in templates #52428

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

eerhardt
Copy link
Member

These entries were missed in #48238. InvariantGlobalization should only be set when the template is created for native AOT. That is the way it is for the worker and grpc templates already. These templates don't support AOT.

Fix #52319

We should also fix this in 8.0.

These entries were missed in dotnet#48238. InvariantGlobalization should only be set when the template is created for native AOT. That is the way it is for the worker and grpc templates already. These templates don't support AOT.

Fix dotnet#52319
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Nov 28, 2023
@eerhardt eerhardt merged commit efd0931 into dotnet:main Nov 29, 2023
26 checks passed
@eerhardt eerhardt deleted the Fix52319 branch November 29, 2023 16:20
@ghost ghost added this to the 9.0-preview1 milestone Nov 29, 2023
eerhardt added a commit to eerhardt/aspnetcore that referenced this pull request Nov 29, 2023
These entries were missed in dotnet#48238. InvariantGlobalization should only be set when the template is created for native AOT. That is the way it is for the worker and grpc templates already. These templates don't support AOT.

Fix dotnet#52319
@julielerman
Copy link

Please yes fix this in 8! It will be so painful for newbies and experienced people alike (who have to head to google when the error throws) as I'm discovering while building demos. Thanks!!

@ghost
Copy link

ghost commented Dec 11, 2023

Hi @julielerman. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@eerhardt
Copy link
Member Author

Please yes fix this in 8! It will be so painful for newbies and experienced people alike (who have to head to google when the error throws) as I'm discovering while building demos. Thanks!!

FYI - the PR to fix it in the 8.0 servicing branch is #52461. It is approved and will be merged when the branch opens again.

@ghost
Copy link

ghost commented Dec 11, 2023

Hi @eerhardt. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

wtgodbe pushed a commit that referenced this pull request Jan 3, 2024
These entries were missed in #48238. InvariantGlobalization should only be set when the template is created for native AOT. That is the way it is for the worker and grpc templates already. These templates don't support AOT.

Fix #52319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
3 participants