Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metrics duration and http.route tag with exception handling #52652

Merged
merged 8 commits into from
Dec 13, 2023
+176 −15

Update src/Shared/HttpExtensions.cs

a166bf4
Select commit
Loading
Failed to load commit list.
Merged

Fix metrics duration and http.route tag with exception handling #52652

Update src/Shared/HttpExtensions.cs
a166bf4
Select commit
Loading
Failed to load commit list.
Azure Pipelines / aspnetcore-components-e2e succeeded Dec 13, 2023 in 50m 55s

Build #20231212.23 had test failures

1 errors / 2 warnings

Details

Tests

  • Failed: 8 (0.60%)
  • Passed: 1,320 (99.32%)
  • Other: 1 (0.08%)
  • Total: 1,329

Annotations

Check failure on line 150532 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-components-e2e

Build log #L150532 

Bash exited with code '1'.

Check failure on line 1 in Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests.ServerEventTest.Cancel_CanTrigger

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-components-e2e

Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests.ServerEventTest.Cancel_CanTrigger 

OpenQA.Selenium.BrowserAssertFailedException : Xunit.Sdk.ContainsException: Assert.Contains() Failure
Not found: oncancel,
In value:  onclose,
   at Microsoft.AspNetCore.E2ETesting.WaitAssert.<>c__DisplayClass17_0.<WaitAssertCore>b__0() in /home/vsts/work/1/s/src/Shared/E2ETesting/WaitAssert.cs:line 83
   at Microsoft.AspNetCore.E2ETesting.WaitAssert.<>c__DisplayClass18_0`1.<WaitAssertCore>b__0(IWebDriver _) in /home/vsts/work/1/s/src/Shared/E2ETesting/WaitAssert.cs:line 101
Screen shot captured at '/home/vsts/work/1/s/src/Components/test/E2ETest/bin/screenshots/f2af4c516b234529a1f5a1bea467c2a7.png'
Encountered browser errors
[2023-12-13T07:28:17Z] [Info] http://127.0.0.1:36033/subdir 56:16 "Blazor server-side"
[2023-12-13T07:28:17Z] [Info] http://127.0.0.1:36033/subdir/_framework/blazor.server.js 0:45030 "[2023-12-13T07:28:17.313Z] Information: Normalizing '_blazor' to 'http://127.0.0.1:36033/subdir/_blazor'."
[2023-12-13T07:28:17Z] [Info] http://127.0.0.1:36033/subdir/_framework/blazor.server.js 0:45030 "[2023-12-13T07:28:17.322Z] Information: WebSocket connected to ws://127.0.0.1:36033/subdir/_blazor?id=bVdYBC7Hk5jvRzdJ0i-cpg."Page content:
<head>
    <meta charset="utf-8">
    <title>Basic test app</title>
    <base href="/subdir/">
    <link href="style.css" rel="stylesheet">
    <link rel="icon" href="data:,">

    <!-- Used by ExternalContentPackage -->
    <link href="_content/TestContentPackage/styles.css" rel="stylesheet">
    <link href="Components.TestServer.styles.css" rel="stylesheet">
</head>
<body>
    <root><!--!--><div id="test-selector"><!--!-->
    Select test:
    <select id="test-selector-select"><option value="none">Choose...</option><!--!-->
        <option value="BasicTestApp.AddRemoveChildComponents">Add/remove child components</option><!--!-->
        <option value="BasicTestApp.AfterRenderInteropComponent">After-render interop component</option><!--!-->
        <option value="BasicTestApp.AsyncEventHandlerComponent">Async event handlers</option><!--!-->
        <option value="BasicTestApp.AuthTest.AuthRouter">Auth cases</option><!--!-->
        <option value="BasicTestApp.AuthTest.CascadingAuthenticationStateParent">Cascading authentication state</option><!--!-->
        <option value="BasicTestApp.BindCasesComponent">bind cases</option><!--!-->
        <option value="BasicTestApp.CascadingValueTest.CascadingValueSupplier">Cascading values</option><!--!-->
        <option value="Components.TestServer.CircuitContextComponent, Components.TestServer, Version=42.42.42.42, Culture=neutral, PublicKeyToken=adb9793829ddae60">Circuit context</option><!--!-->
        <option value="BasicTestApp.ComponentRefComponent">Component ref component</option><!--!-->
        <option value="BasicTestApp.ConcurrentRenderParent">Concurrent rendering</option><!--!-->
        <option value="BasicTestApp.ConfigurationComponent">Configuration</option><!--!-->
        <option value="BasicTestApp.ConfigureRuntime">Configure runtime</option><!--!-->
        <option value="BasicTestApp.ContentEditable">Content-editable</option><!--!-->
        <option value="BasicTestApp.CounterComponent">Counter</option><!--!-->
        <option value="BasicTestApp.CounterComponentUsingChild">Counter using child component</option><!--!-->
        <option value="BasicTestApp.CounterComponentWrapper">Counter wrapped in parent</option><!--!-->
        <option value="BasicTestApp.CulturePicker">Culture Picker</option><!--!-->
        <option value="BasicTestApp.CustomElementsComponent">Custom elements</option><!--!-->
        <option value="BasicTestApp.DataDashComponent">data-* attribute rendering</option><!--!-->
        <option value="BasicTestApp.DispatchingComponent">Dispatching to sync context</option><!--!-->
        <option value="BasicTestApp.DuplicateAttributesComponent">Duplicate attributes</option><!--!-->
        <option value="BasicTestApp.DynamicComponentRendering">DynamicComponent rendering</option><!--!-->
        <option value="Basi
Raw output 
   at Microsoft.AspNetCore.E2ETesting.WaitAssert.WaitAssertCore[TResult](IWebDriver driver, Func`1 assertion, TimeSpan timeout) in /home/vsts/work/1/s/src/Shared/E2ETesting/WaitAssert.cs:line 129
   at Microsoft.AspNetCore.E2ETesting.WaitAssert.WaitAssertCore(IWebDriver driver, Action assertion, TimeSpan timeout) in /home/vsts/work/1/s/src/Shared/E2ETesting/WaitAssert.cs:line 83
   at Microsoft.AspNetCore.E2ETesting.WaitAssert.Contains(IWebDriver driver, String expectedSubstring, Func`1 actualString) in /home/vsts/work/1/s/src/Shared/E2ETesting/WaitAssert.cs:line 42
   at Microsoft.AspNetCore.Components.E2ETest.Tests.EventTest.Cancel_CanTrigger() in /home/vsts/work/1/s/src/Components/test/E2ETest/Tests/EventTest.cs:line 217
   at InvokeStub_EventTest.Cancel_CanTrigger(Object, Object, IntPtr*)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
----- Inner Stack Trace -----
   at Microsoft.AspNetCore.E2ETesting.WaitAssert.<>c__DisplayClass17_0.<WaitAssertCore>b__0() in /home/vsts/work/1/s/src/Shared/E2ETesting/WaitAssert.cs:line 83
   at Microsoft.AspNetCore.E2ETesting.WaitAssert.<>c__DisplayClass18_0`1.<WaitAssertCore>b__0(IWebDriver _) in /home/vsts/work/1/s/src/Shared/E2ETesting/WaitAssert.cs:line 101

Check failure on line 1 in Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests.CircuitTests.ComponentLifecycleMethodThrowsExceptionTerminatesTheCircuit(id: "afterrender-async-throw")

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-components-e2e

Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests.CircuitTests.ComponentLifecycleMethodThrowsExceptionTerminatesTheCircuit(id: "afterrender-async-throw") 

OpenQA.Selenium.ElementClickInterceptedException : element click intercepted: Element <button id="afterrender-async-throw">...</button> is not clickable at point (189, 450). Other element would receive the click: <div id="blazor-error-ui" style="display: block;">...</div>
  (Session info: chrome=120.0.6099.71)
Raw output 
   at OpenQA.Selenium.WebDriver.UnpackAndThrowOnError(Response errorResponse, String commandToExecute)
   at OpenQA.Selenium.WebDriver.Execute(String driverCommandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebElement.Execute(String commandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebElement.Click()
   at Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests.CircuitTests.ComponentLifecycleMethodThrowsExceptionTerminatesTheCircuit(String id) in /home/vsts/work/1/s/src/Components/test/E2ETest/Tests/CircuitTests.cs:line 51
   at InvokeStub_CircuitTests.ComponentLifecycleMethodThrowsExceptionTerminatesTheCircuit(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Check failure on line 1 in Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests.ServerComponentRenderingTest.CanUseFocusExtensionToFocusElementPreventScroll

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-components-e2e

Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests.ServerComponentRenderingTest.CanUseFocusExtensionToFocusElementPreventScroll 

Assert.Equal() Failure
Expected: 76
Actual:   0
Raw output 
   at Microsoft.AspNetCore.Components.E2ETest.Tests.ComponentRenderingTestBase.CanUseFocusExtensionToFocusElementPreventScroll() in /home/vsts/work/1/s/src/Components/test/E2ETest/Tests/ComponentRenderingTestBase.cs:line 454
   at InvokeStub_ComponentRenderingTestBase.CanUseFocusExtensionToFocusElementPreventScroll(Object, Object, IntPtr*)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests.CircuitTests.ComponentLifecycleMethodThrowsExceptionTerminatesTheCircuit(id: "afterrender-sync-throw")

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-components-e2e

Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests.CircuitTests.ComponentLifecycleMethodThrowsExceptionTerminatesTheCircuit(id: "afterrender-sync-throw") 

OpenQA.Selenium.ElementClickInterceptedException : element click intercepted: Element <button id="afterrender-sync-throw">...</button> is not clickable at point (405, 432). Other element would receive the click: <div id="blazor-error-ui" style="display: block;">...</div>
  (Session info: chrome=120.0.6099.71)
Raw output 
   at OpenQA.Selenium.WebDriver.UnpackAndThrowOnError(Response errorResponse, String commandToExecute)
   at OpenQA.Selenium.WebDriver.Execute(String driverCommandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebElement.Click()
   at Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests.CircuitTests.ComponentLifecycleMethodThrowsExceptionTerminatesTheCircuit(String id) in /home/vsts/work/1/s/src/Components/test/E2ETest/Tests/CircuitTests.cs:line 51
   at InvokeStub_CircuitTests.ComponentLifecycleMethodThrowsExceptionTerminatesTheCircuit(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
View more details on Azure Pipelines