[main] Update dependencies from dotnet/arcade #53528

dotnet-maestro · 2024-01-22T13:07:16Z

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

Subscription: 89b8d7af-c2e7-42f8-3b29-08d8b8050dda
Build: 20240229.2
Date Produced: February 29, 2024 6:24:27 PM UTC
Commit: 85ae8b264f3312aac5ca08dcab039556e99fcb00
Branch: refs/heads/main

Updates:
- Microsoft.SourceBuild.Intermediate.arcade: from 9.0.0-beta.24062.5 to 9.0.0-beta.24129.2
- Microsoft.DotNet.Arcade.Sdk: from 9.0.0-beta.24062.5 to 9.0.0-beta.24129.2
- Microsoft.DotNet.Build.Tasks.Installers: from 9.0.0-beta.24062.5 to 9.0.0-beta.24129.2
- Microsoft.DotNet.Build.Tasks.Templating: from 9.0.0-beta.24062.5 to 9.0.0-beta.24129.2
- Microsoft.DotNet.Helix.Sdk: from 9.0.0-beta.24062.5 to 9.0.0-beta.24129.2
- Microsoft.DotNet.RemoteExecutor: from 9.0.0-beta.24062.5 to 9.0.0-beta.24129.2

…119.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor From Version 9.0.0-beta.24062.5 -> To Version 9.0.0-beta.24069.2

sebastienros · 2024-01-23T18:14:31Z

/azp run

azure-pipelines · 2024-01-23T18:14:47Z

Azure Pipelines successfully started running 3 pipeline(s).

eerhardt · 2024-01-26T17:54:29Z

@mkArtakMSFT @javiercn @SteveSandersonMS - it looks like the e2e Blazor tests are failing. Can someone take a look?

OpenQA.Selenium.BrowserAssertFailedException : Xunit.Sdk.NotEqualException: Assert.NotEqual() Failure
Expected: Not "Current count: 0"
Actual:   "Current count: 0"
   at Xunit.Assert.NotEqual[T](T expected, T actual, IEqualityComparer`1 comparer) in /_/src/xunit.assert/Asserts/EqualityAsserts.cs:line 302
   at Microsoft.AspNetCore.E2ETesting.WaitAssert.<>c__DisplayClass18_0`1.<WaitAssertCore>b__0(IWebDriver _) in /home/vsts/work/1/s/src/Shared/E2ETesting/WaitAssert.cs:line 101
Screen shot captured at '/home/vsts/work/1/s/src/Components/test/E2ETest/bin/screenshots/763e05b0cc034d0da156a1e0147b3828.png'
Encountered browser errors
[2024-01-23T19:18:27Z] [Info] http://127.0.0.1:46683/_framework/dotnet.native.9.0.0-alpha.1.24066.33.skl7xdoebu.js 7:20879 "System.Exception: We should have thrown here!"
[2024-01-23T19:18:27Z] [Info] http://127.0.0.1:46683/_framework/dotnet.native.9.0.0-alpha.1.24066.33.skl7xdoebu.js 7:20879 "   at ThreadingApp.Pages.Counter.TestThreads()"
[2024-01-23T19:18:27Z] [Severe] http://127.0.0.1:46683/_framework/blazor.webassembly.js 0:45287 "crit: Microsoft.AspNetCore.Components.WebAssembly.Rendering.WebAssemblyRenderer[100]\n      Unhandled exception rendering component: We should have thrown here!\nSystem.Exception: We should have thrown here!\n   at ThreadingApp.Pages.Counter.TestThreads()\n   at Microsoft.AspNetCore.Components.ComponentBase.CallStateHasChangedOnAsyncCompletion(Task task)\n   at Microsoft.AspNetCore.Components.RenderTree.Renderer.GetErrorHandledTask(Task , ComponentState )"Page content:
<head>
    <meta charset="utf-8">
    <!-- Forcing the device width here so that our automated tests work consistently on mobile browsers. -->
    <meta name="viewport" content="width=1024">
    <title>Blazor standalone</title>
    <base href="/">
</head>
<body>
    <app><!--!--><!--!--><!--!--><!--!--><div class="sidebar"><!--!--><div class="top-row pl-4 navbar navbar-dark"><!--!--><a class="navbar-brand" href="">Blazor app</a>
    <button class="navbar-toggler"><!--!--><span class="navbar-toggler-icon"></span></button></div><!--!-->

<div><ul class="nav flex-column"><li class="nav-item px-3"><!--!--><a href="" class="nav-link"><!--!--><span class="bi bi-house-door-fill" aria-hidden="true"></span> Home
            </a></li><!--!-->
        <li class="nav-item px-3"><!--!--><a href="counter" class="nav-link active" aria-current="page"><!--!--><span class="bi bi-plus-square-fill" aria-hidden="true"></span> Counter
            </a></li><!--!-->
        <li class="nav-item px-3"><!--!--><a href="fetchdata" class="nav-link"><!--!--><span class="bi bi-list-nested" aria-hidden="true"></span> Fetch data
            </a></li></ul></div></div><!--!-->

<div class="main"><!--!--><div class="top-row px-4"><a href="http://blazor.net" target="_blank" class="ml-md-auto">About</a></div>

    <div class="content px-4"><!--!--><!--!--><h1 tabindex="-1">Counter</h1>

<p>Current count: 0</p><!--!-->

<button class="btn btn-primary">Click me</button><!--!-->
<button class="btn btn-primary" id="TestThreads">Test threads</button></div></div><!--!-->
        <!--!--></app>

    <div id="blazor-error-ui" style="display: block;">
        An unhandled exception has occurred. See browser dev tools for details.
        <a href="" class="reload">Reload</a>
        <a class="dismiss">\ud83d\uddd9</a>
    </div>

    <script src="_framework/blazor.webassembly.js" autostart="false"></script>
    <script>
        (function(){
            Blazor.start().then(function () {
                window['__aspnetcore__testing__blazor_wasm__started__'] = true;
            });
        })();
    </script>


</body>

---- Assert.NotEqual() Failure
Expected: Not "Current count: 0"
Actual:   "Current count: 0"

javiercn · 2024-01-26T18:05:02Z

@eerhardt I think that might be a flaky test

…126.5 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor From Version 9.0.0-beta.24062.5 -> To Version 9.0.0-beta.24076.5

eerhardt · 2024-01-29T21:26:07Z

@mthalman @MichaelSimons - we are getting a source build break with the new version of arcade:

.packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24076.5/tools/SourceBuild/AfterSourceBuild.proj(80,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 8 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
MicroBuild.Core.0.2.0
MicroBuild.Core.Sentinel.1.0.0
Microsoft.DotNet.Build.Tasks.Feed.9.0.0-beta.24076.5
Microsoft.DotNet.Build.Tasks.VisualStudio.9.0.0-beta.24076.5
Microsoft.Signed.Wix.1.0.0-v3.14.0.5722
Microsoft.SymbolUploader.Build.Task.2.0.0-preview.1.23470.14
sn.1.0.0
vswhere.2.6.7

I'm not sure how we can resolve this. Is this an issue with arcade?

mthalman · 2024-01-29T22:26:52Z

@mthalman @MichaelSimons - we are getting a source build break with the new version of arcade:

.packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24076.5/tools/SourceBuild/AfterSourceBuild.proj(80,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 8 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
MicroBuild.Core.0.2.0
MicroBuild.Core.Sentinel.1.0.0
Microsoft.DotNet.Build.Tasks.Feed.9.0.0-beta.24076.5
Microsoft.DotNet.Build.Tasks.VisualStudio.9.0.0-beta.24076.5
Microsoft.Signed.Wix.1.0.0-v3.14.0.5722
Microsoft.SymbolUploader.Build.Task.2.0.0-preview.1.23470.14
sn.1.0.0
vswhere.2.6.7

I'm not sure how we can resolve this. Is this an issue with arcade?

@mmitche - I think this may be due to your change from dotnet/arcade#14411 since that is touching where these packages are referenced by Arcade.

cc @dotnet/source-build-internal

mmitche · 2024-01-30T16:53:34Z

Yes that's probably me. This is surprising though....maybe this has to do with aspnet's custom logic to build its build tasks.
dotnet/source-build#3807

…202.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor From Version 9.0.0-beta.24062.5 -> To Version 9.0.0-beta.24102.4

javiercn · 2024-02-13T08:37:54Z

/azp run aspnetcore-ci

azure-pipelines · 2024-02-13T08:38:04Z

Azure Pipelines successfully started running 1 pipeline(s).

javiercn · 2024-02-13T08:38:14Z

/azp run aspnetcore-components-e2e

azure-pipelines · 2024-02-13T08:38:21Z

Azure Pipelines successfully started running 1 pipeline(s).

javiercn · 2024-02-14T13:21:19Z

@wtgodbe can you take a look?

javiercn · 2024-02-14T16:44:27Z

@MichaelSimons seems that there is still a source build related issue here

mthalman · 2024-02-14T16:53:07Z

The failure was earlier identified in #53528 (comment).

@mmitche - What's the resolution here?

MichaelSimons · 2024-02-14T20:50:32Z

This looks to be coming from the BuildRepoTasks. In this case _ImportOrUseTooling is set to true after dotnet/arcade#14411 was merged. Prior to this the package weren't imported because DotNetBuildFromSource was true.

@mmitche - do you think DotNetBuildSourceOnly should be flown into this BuildRepoTasks invocation? Else does the _ImportOrUseTooling property need to be "exposed for this use case? IDK

SteveSandersonMS · 2024-02-15T13:47:34Z

Blocked on dotnet/source-build#3807 (as per statement at https://github.com/dotnet/aspnetcore-internal/issues/4461)

…214.1 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor From Version 9.0.0-beta.24062.5 -> To Version 9.0.0-beta.24114.1

mmitche · 2024-02-28T00:48:47Z

Hmm..that didn't do it..._ImportOrUseTooling ended up false, but same/similar error. Will need more investigation tomorrow.

mmitche · 2024-02-28T18:13:59Z

I think my other aspnetcore change depends on this. Prioritizing this.

mmitche · 2024-02-28T23:13:33Z

Update: At this point I don't see a totally obvious link between the control update and this failure. What I am seeing is the following:

The runtime pack and crossgen packs are not restored in the failing SB version.
LatestPackageReference actually contains 2 items for crossgen and the runtime

vs.

…482a-44eb-8859-45b8b9099279

mmitche · 2024-02-29T00:06:53Z

Update: Removing DotNetBuildRepo and DotNetBuildSourceOnly from the root invocation does not fail. In addition, it should be noted that this works in the VMR right now, so another clue.

mmitche · 2024-02-29T20:49:27Z

I think I've spotted it. f9d0d6b from @tmds enabled portable builds of unknown arches. This happens under DotNetBuildSourceOnly, but at the time when he checked in, we didn't have DotNetBuildSourceOnly in this repo yet. So it wasn't getting passed in. Now that it is, f9d0d6b#diff-9e65f6e7d94b1416538b21399c17de70960df5df64f272b56ce23868f12a7469R134 pulls in the same crossgen and runtime packs twice.

mmitche · 2024-02-29T22:49:37Z

Okay I think that does it. @wtgodbe to review the tweak to LatestPackageReference

mmitche · 2024-02-29T22:58:28Z

Agh, that latest issue is msbuild picking up the command line error. Should be fixed in latest arcade.

…229.2 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor From Version 9.0.0-beta.24062.5 -> To Version 9.0.0-beta.24129.2

tmds · 2024-03-01T04:21:42Z

I think I've spotted it. f9d0d6b from @tmds enabled portable builds of unknown arches. This happens under DotNetBuildSourceOnly, but at the time when he checked in, we didn't have DotNetBuildSourceOnly in this repo yet.

Thanks for fixing the issue!

When making this change I had done some validation, but all these builds involved rids that didn't cause duplicates here.

These were vmr builds, so I assume something must have been setting DotNetBuildSourceOnly to true in these build for aspnetcore or the change I made wouldn't have had an effect.

the tweak to LatestPackageReference

I think you could also prevent the duplicate by adding an Exclude like:

<LatestPackageReference Include="Microsoft.NETCore.App.Runtime.$(TargetRuntimeIdentifier)" Exclude="@(LatestPackageReference)" Condition=" '$(DotNetBuildSourceOnly)' == 'true' " />

mmitche · 2024-03-01T15:33:22Z

I think you could also prevent the duplicate by adding an Exclude like:

Ooh I like that better than the dedupe. Will switch over. And yeah, aspnetcore hadn't had an arcade update yet that was setting the new flags.

wtgodbe

LGTM, but can you undo the submodule change?

This reverts commit 7ccf516.

…482a-44eb-8859-45b8b9099279

dotnet-maestro bot requested review from wtgodbe and a team as code owners January 22, 2024 13:07

dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 22, 2024

build-analysis bot mentioned this pull request Jan 23, 2024

Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009

Open

2 tasks

amcasey mentioned this pull request Feb 1, 2024

[dev] Update dependencies from dotnet/arcade dotnet/extensions#4896

Merged

dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 12, 2024

wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024

javiercn added 2 commits February 13, 2024 09:01

Merge branch 'main' into darc-main-b53c7ee8-482a-44eb-8859-45b8b9099279

cd8b024

Fix Version.Details.xml

de346ee

Fix incorrect shas from manual merge.

9b95392

mmitche added 3 commits February 28, 2024 15:37

Merge remote-tracking branch 'upstream/main' into darc-main-b53c7ee8-…

8a9624a

…482a-44eb-8859-45b8b9099279

Propagate some additional properties

a4a06a3

Unpropagate some additional properties

99755d0

mmitche added 6 commits February 29, 2024 12:54

Only add if not already added.

0702e33

Only add if not already added.

2ef4dcf

Keep Duplicates=false.

781e6fa

Odd

576bb08

New approach

156ff68

More feeling

13bdba7

dotnet-maestro bot and others added 3 commits February 29, 2024 22:59

Attempt using 17,8

7ccf516

wtgodbe approved these changes Mar 1, 2024

View reviewed changes

mmitche added 4 commits March 1, 2024 08:06

Revert "Attempt using 17,8"

22e400f

This reverts commit 7ccf516.

Temporarily switch to VS preview queues

99e19ec

Merge remote-tracking branch 'upstream/main' into darc-main-b53c7ee8-…

0d7e601

…482a-44eb-8859-45b8b9099279

Revert googletest

3534839

dotnet-maestro bot merged commit 6cfd675 into main Mar 1, 2024
28 checks passed

dotnet-maestro bot deleted the darc-main-b53c7ee8-482a-44eb-8859-45b8b9099279 branch March 1, 2024 18:59

dotnet-policy-service bot added this to the 9.0-preview3 milestone Mar 1, 2024

tmds mentioned this pull request Apr 2, 2024

Enable portable cross-arch source-building to unknown architectures. #54031

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/arcade #53528

[main] Update dependencies from dotnet/arcade #53528

dotnet-maestro bot commented Jan 22, 2024 •

edited

Loading

sebastienros commented Jan 23, 2024

azure-pipelines bot commented Jan 23, 2024

eerhardt commented Jan 26, 2024

javiercn commented Jan 26, 2024

eerhardt commented Jan 29, 2024

mthalman commented Jan 29, 2024

mmitche commented Jan 30, 2024

javiercn commented Feb 13, 2024

azure-pipelines bot commented Feb 13, 2024

javiercn commented Feb 13, 2024

azure-pipelines bot commented Feb 13, 2024

javiercn commented Feb 14, 2024

javiercn commented Feb 14, 2024

mthalman commented Feb 14, 2024

MichaelSimons commented Feb 14, 2024

SteveSandersonMS commented Feb 15, 2024

mmitche commented Feb 28, 2024

mmitche commented Feb 28, 2024

mmitche commented Feb 28, 2024

mmitche commented Feb 29, 2024

mmitche commented Feb 29, 2024

mmitche commented Feb 29, 2024

mmitche commented Feb 29, 2024

tmds commented Mar 1, 2024

mmitche commented Mar 1, 2024

wtgodbe left a comment

[main] Update dependencies from dotnet/arcade #53528

[main] Update dependencies from dotnet/arcade #53528

Conversation

dotnet-maestro bot commented Jan 22, 2024 • edited Loading

From https://github.com/dotnet/arcade

sebastienros commented Jan 23, 2024

azure-pipelines bot commented Jan 23, 2024

eerhardt commented Jan 26, 2024

javiercn commented Jan 26, 2024

eerhardt commented Jan 29, 2024

mthalman commented Jan 29, 2024

mmitche commented Jan 30, 2024

javiercn commented Feb 13, 2024

azure-pipelines bot commented Feb 13, 2024

javiercn commented Feb 13, 2024

azure-pipelines bot commented Feb 13, 2024

javiercn commented Feb 14, 2024

javiercn commented Feb 14, 2024

mthalman commented Feb 14, 2024

MichaelSimons commented Feb 14, 2024

SteveSandersonMS commented Feb 15, 2024

mmitche commented Feb 28, 2024

mmitche commented Feb 28, 2024

mmitche commented Feb 28, 2024

mmitche commented Feb 29, 2024

mmitche commented Feb 29, 2024

mmitche commented Feb 29, 2024

mmitche commented Feb 29, 2024

tmds commented Mar 1, 2024

mmitche commented Mar 1, 2024

wtgodbe left a comment

Choose a reason for hiding this comment

dotnet-maestro bot commented Jan 22, 2024 •

edited

Loading