[release/8.0] Fix route analyzer performance with highly concatenated strings #54763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
… string concatenations
…outePatternAnalyzerTests.cs Co-authored-by: Martin Costello <martin@martincostello.com>
dotnet-issue-labeler
bot
added
the
area-infrastructure
captainsafia
approved these changes
Mar 26, 2024
mkArtakMSFT
added
area-minimal
JamesNK
added
Servicing-approved
mitchdenny
approved these changes
Apr 2, 2024
oskogstad
referenced
this pull request
in digdir/dialogporten
May 26, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Microsoft.AspNetCore.Authentication.JwtBearer](https://asp.net/) ([source](https://github.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.AspNetCore.Mvc.NewtonsoftJson](https://asp.net/) ([source](https://github.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.AspNetCore.OpenApi](https://asp.net/) ([source](https://github.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.EntityFrameworkCore.Relational](https://docs.microsoft.com/ef/core/) ([source](https://github.com/dotnet/efcore)) | `8.0.4` -> `8.0.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.EntityFrameworkCore.Tools](https://docs.microsoft.com/ef/core/) ([source](https://github.com/dotnet/efcore)) | `8.0.4` -> `8.0.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.Extensions.Caching.StackExchangeRedis](https://asp.net/) ([source](https://github.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Microsoft.Extensions.Http.Polly](https://asp.net/) ([source](https://github.com/dotnet/aspnetcore)) | `8.0.4` -> `8.0.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>dotnet/aspnetcore (Microsoft.AspNetCore.Authentication.JwtBearer)</summary> ### [`v8.0.5`](https://github.com/dotnet/aspnetcore/releases/tag/v8.0.5): .NET 8.0.5 [Release](https://github.com/dotnet/core/releases/tag/v8.0.5) ##### What's Changed - \[release/8.0] Update dependencies from dotnet/source-build-externals by [@​dotnet-maestro](https://github.com/dotnet-maestro) in [https://github.com/dotnet/aspnetcore/pull/54744](https://github.com/dotnet/aspnetcore/pull/54744) - Update branding to 8.0.5 by [@​vseanreesermsft](https://github.com/vseanreesermsft) in [https://github.com/dotnet/aspnetcore/pull/54907](https://github.com/dotnet/aspnetcore/pull/54907) - \[release/8.0] Convert to 1ES templates by [@​RussKie](https://github.com/RussKie) in [https://github.com/dotnet/aspnetcore/pull/54660](https://github.com/dotnet/aspnetcore/pull/54660) - Increase logs and delays in CanLaunchPhotinoWebViewAndClickButton by [@​Eilon](https://github.com/Eilon) in [https://github.com/dotnet/aspnetcore/pull/54608](https://github.com/dotnet/aspnetcore/pull/54608) - \[release/8.0] (deps): Bump src/submodules/googletest from `31993df` to `77afe8e` by [@​dependabot](https://github.com/dependabot) in [https://github.com/dotnet/aspnetcore/pull/54872](https://github.com/dotnet/aspnetcore/pull/54872) - \[release/8.0] Reduce helix-matrix timeout to 5 hours by [@​github-actions](https://github.com/github-actions) in [https://github.com/dotnet/aspnetcore/pull/54778](https://github.com/dotnet/aspnetcore/pull/54778) - \[release/8.0] Preserve RemoteAuthenticationContext during trimming if used in JS interop by [@​halter73](https://github.com/halter73) in [https://github.com/dotnet/aspnetcore/pull/54655](https://github.com/dotnet/aspnetcore/pull/54655) - \[release/8.0] Improve usage of `Type.GetType` when activating types in data protection by [@​github-actions](https://github.com/github-actions) in [https://github.com/dotnet/aspnetcore/pull/54762](https://github.com/dotnet/aspnetcore/pull/54762) - \[release/8.0] Fix route analyzer performance with highly concatenated strings by [@​github-actions](https://github.com/github-actions) in [https://github.com/dotnet/aspnetcore/pull/54763](https://github.com/dotnet/aspnetcore/pull/54763) - \[release/8.0] Suppress .ps1 SDL errors by [@​wtgodbe](https://github.com/wtgodbe) in [https://github.com/dotnet/aspnetcore/pull/54915](https://github.com/dotnet/aspnetcore/pull/54915) - \[release/8.0] Backport test fixes by [@​MackinnonBuck](https://github.com/MackinnonBuck) in [https://github.com/dotnet/aspnetcore/pull/54912](https://github.com/dotnet/aspnetcore/pull/54912) - \[release/8.0] Skip SpotBugs for now by [@​wtgodbe](https://github.com/wtgodbe) in [https://github.com/dotnet/aspnetcore/pull/54952](https://github.com/dotnet/aspnetcore/pull/54952) - Merging internal commits for release/8.0 by [@​vseanreesermsft](https://github.com/vseanreesermsft) in [https://github.com/dotnet/aspnetcore/pull/55034](https://github.com/dotnet/aspnetcore/pull/55034) - \[release/8.0] Update dependencies from dotnet/arcade by [@​dotnet-maestro](https://github.com/dotnet-maestro) in [https://github.com/dotnet/aspnetcore/pull/55061](https://github.com/dotnet/aspnetcore/pull/55061) - \[release/8.0] Update Wix version by [@​github-actions](https://github.com/github-actions) in [https://github.com/dotnet/aspnetcore/pull/55101](https://github.com/dotnet/aspnetcore/pull/55101) **Full Changelog**: dotnet/aspnetcore@v8.0.4...v8.0.5 </details> <details> <summary>dotnet/efcore (Microsoft.EntityFrameworkCore.Relational)</summary> ### [`v8.0.5`](https://github.com/dotnet/efcore/releases/tag/v8.0.5): EF Core 8.0.5 This is a [patch release of EF Core 8.0](https://www.nuget.org/packages/Microsoft.EntityFrameworkCore/8.0.5) containing only updates to dependencies. There are no additional fixes in this release beyond those already shipped in EF Core 8.0.4. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 7am on Sunday,before 7am on Wednesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/digdir/dialogporten). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ole Jørgen Skogstad <skogstad@softis.net>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #54479 to release/8.0
/cc @JamesNK
Fix route analyzer performance with highly concatenated strings
Route analyzer introduced in .NET 8 can cause very long build times in some projects. A highly concatenated string in a C# file causes a lot of time to be spent in Roslyn's
GetLeadingTriviamethod. Many concatenated strings cause O(N^2) calls to this relatively expensive method.For example,
"x1" + "x2" + "x3" + "x4" + ... "x1000"will greatly increase build times by callingGetLeadingTrivia1 million times. There isn't a limit to the number of string concats so performance gets worse the more string concats.The fix is to skip analyzing concatenated strings. This improves performance and is better behavior. The analyzer isn't designed to analyze content spread across multiple string fragments. Note that Roslyn has the same issue (although their performance impact is smaller) and has implemented the same code fix - dotnet/roslyn#72620.
Fixes #54293
Fixes #53899
Customer Impact
Multiple customers have reported 5+ second increase in build time. They have code generation tools that produce hundreds of string concats in output C#.
Customers can work around this issue by disabling the slow analyzer. However, there is no indication that poor performance is linked to an analyzer. Customers are unlikely to find the fix themselves.
Regression?
Projects with highly concatenated strings that are built fast in .NET 7 are slow after updating to .NET 8.
Risk
A small, isolated change to an analyzer.
Verification
Manual testing using the framework samples project (note: part of aspnetcore solution so build performance has some overhead)
Before:
After:
Packaging changes reviewed?
When servicing release/2.1