using one style approach for all 3 configs WebAssembly, Web and Server #56758
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-blazor
dotnet-policy-service
bot
added
the
community-contribution
This comment was marked as resolved.
This comment was marked as resolved.
|
@javiercn can you please review this? Thanks! |
dotnet-policy-service
bot
added
the
pending-ci-rerun
|
Commenter does not have sufficient privileges for PR 56758 in repo dotnet/aspnetcore |
/azp run |
|
Hi there, @javiercn @mkArtakMSFT, I don't have sufficient permissions to rerun the ci. What are the next steps for this PR? |
|
@vladimir-shirmanov we need some E2E tests (either new ones, or modify existing ones) to make sure that things are working and we don't break this in the future. |
Ok, let me think how to do that. Thanks |
|
Related to #54649. We'd only want to take one of these changes, as they do the same thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Blazor] Accept the blazor.web.js startup options format in blazor.{server|webassembly}.js
Description
Added config properties to blazor.{server|webassembly}.js to follow the same structure as blazor.web.js
Fixes #51611