Fix code generation for parsing optional array parameters in RequestDelegateGenerator

[ithline]

Fix code generation for parsing optional array parameters in RequestDelegateGenerator

• You've read the Contributor Guide and Code of Conduct.
• You've included unit or integration tests for your change, where applicable.
• You've included inline docs for your change, where applicable.
• There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

This PR aims to fix the invalid code generated for optional arrays in RequestDelegateGenerator (RDG), where the generated code tried to assign single element value into array variable.

The EndpointParameter.ParsingBlockEmitter property was lifted out of EndpointParameter.TryGetParsability into EndpointParameterEmitter.EmitParsingBlock method, to be able to properly condition all the parsing paths.

I added 4 tests to cover the code path, but commented out VerifyAgainstBaselineUsingFile check. I can add them, but will need guidance on how to use this part of test infrastructure.

This PR also contains a simple fix to SupportsSingleKeyedServiceWithPrimitiveKeyTypes test, that failed to compile on my machine due to culture specific handling of decimal point. I replaced simple .ToString() call with Convert.ToString({value}, CultureInfo.InvariantCulture) to force the value to be consistent across cultures.

Fixes #57175

[ithline]

@dotnet-policy-service agree

[captainsafia]

I added 4 tests to cover the code path, but commented out VerifyAgainstBaselineUsingFile check. I can add them, but will need guidance on how to use this part of test infrastructure.

This is our bespoke snapshot testing infrastructure. In order to use it, you'll have to add the call to the target unit test method, set this property in the test base class to true, run the test suite, reset the value of the property, then run the test suite again to observe the resulting behavior without this Assert.Fail spoiling your fun.

Since we create a snapshot for each test method, I like to create a single test method that contains a test source with multiple endpoints with the conditions to test.

This PR also contains a simple fix to SupportsSingleKeyedServiceWithPrimitiveKeyTypes test, that failed to compile on my machine due to culture specific handling of decimal point. I replaced simple .ToString() call with Convert.ToString({value}, CultureInfo.InvariantCulture) to force the value to be consistent across cultures.

Thanks for this fix! We've got a few of these kinds of issues in the codebase since our team/CI machines primarily use an en-US culture. We should probably figure out a way to be resilient to this that doesn't rely on people with different locales running the test suite... 😅

[ithline]

@captainsafia Alright, I've added the missing baseline tests and this PR should be ready for review.

[captainsafia]

We can probably exclude the baseline here since the generated code between MapAction_ExplicitQuery_IntArrayParam_Optional_QueryNotPresent and MapAction_ExplicitQuery_IntArrayParam_Optional is the same.

Alternatively, we could do one test method that uses a [Theory] to test the scenario where a query is present and the one where it is not.

[captainsafia]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).