Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Templates] Generate single test HTTPS Certificate #57431

Merged
merged 11 commits into from
Aug 21, 2024

Conversation

javiercn
Copy link
Member

  • Generates a single HTTPS certificate for tests instead of one per test.

* Generates a single HTTPS certificate for tests instead of one per test.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Aug 20, 2024
@amcasey
Copy link
Member

amcasey commented Aug 20, 2024

Could we just check one in? I'm pretty sure the kestrel tests just have a folder of pre-made certs with various characteristics.

Edit: Oh, I see you're actually creating a real dev cert. Well, be careful about cert trust.

@amcasey amcasey added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Aug 20, 2024
@javiercn javiercn closed this Aug 21, 2024
@javiercn javiercn reopened this Aug 21, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Aug 21, 2024
@javiercn
Copy link
Member Author

/azp run aspnetcore-ci

Copy link

Pipelines were unable to run due to time out waiting for the pull request to finish merging.

@javiercn javiercn closed this Aug 21, 2024
@javiercn javiercn reopened this Aug 21, 2024
@javiercn javiercn closed this Aug 21, 2024
@javiercn javiercn reopened this Aug 21, 2024
@javiercn javiercn marked this pull request as ready for review August 21, 2024 16:30
@javiercn javiercn requested review from wtgodbe and a team as code owners August 21, 2024 16:30
@javiercn
Copy link
Member Author

Edit: Oh, I see you're actually creating a real dev cert. Well, be careful about cert trust.

These tests don't trust the cert in any way. They setup Selenium/Playwright/Dotnet to bypass the trust.

Co-authored-by: Stephen Halter <halter73@gmail.com>
@javiercn javiercn merged commit d65f5c4 into main Aug 21, 2024
26 checks passed
@javiercn javiercn deleted the javiercn/improve-template-tests-certs branch August 21, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants