Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some tests from helix retry list #57539

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Conversation

radical
Copy link
Member

@radical radical commented Aug 26, 2024

@radical radical requested review from wtgodbe and a team as code owners August 26, 2024 23:30
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 26, 2024
@radical
Copy link
Member Author

radical commented Aug 26, 2024

These tests also haven't failed in the last month:

{"testName": {"contains": "MaxRequestBufferSizeTests.LargeUpload" }}, // tries to manipulate the state of the server's buffer
{"testName": {"contains": "CertificateChangedOnDisk"}}, // depends on FS event timing
{"testName": {"contains": "CertificateChangedOnDisk_Symlink"}}, // depends on FS event timing

@wtgodbe can these be removed, or are they expected to inherently fail some times?

@radical radical enabled auto-merge (squash) August 27, 2024 20:17
@radical radical merged commit b67e95d into dotnet:main Aug 27, 2024
26 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
2 participants