You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blazor's error UI was overlaying the button that the test was trying to click. This PR fixes the issue by scrolling the button into view before attempting to click it.
The reason will be displayed to describe this comment to others. Learn more.
Nice! If this is a reliable fix, you could probably unquarantine the tests at the same time (since they were not actually flaky but 100% failing all the time).
Do we know why it only recently started failing? And what other branches this might affect?
I'm not totally sure, but it seems related to the testing environment. The way I was able to repro this was shrinking the browser window vertically. I tried various Chrome versions to see if it that was the cause, but it didn't make a difference.
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.
area-blazorIncludes: Blazor, Razor Components* NO MERGE *Do not merge this PR as long as this label is present.pending-ci-rerunWhen assigned to a PR indicates that the CI checks should be rerun
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotnet-issue-labeler
bot
added
the
area-blazor
MackinnonBuck
added
the
* NO MERGE *
dotnet-policy-service
bot
added
the
pending-ci-rerun
Blazor's error UI was overlaying the button that the test was trying to click. This PR fixes the issue by scrolling the button into view before attempting to click it.
Marks #57551 as
test-fixed.