Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Readme.md in packages #57809

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Include Readme.md in packages #57809

merged 5 commits into from
Sep 12, 2024

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Sep 11, 2024 •
edited
Loading

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 11, 2024
This was referenced Sep 11, 2024
Open
Open
@wtgodbe wtgodbe marked this pull request as ready for review September 11, 2024 22:13
@wtgodbe wtgodbe requested review from MackinnonBuck and a team September 11, 2024 22:13
@wtgodbe
Copy link
Member Author

wtgodbe commented Sep 11, 2024

Test build worked, Microsoft.AspNetCore.Authentication.JwtBearer now has a Package.md, while other packages without a checked in Readme have nothing

wtgodbe
wtgodbe commented Sep 11, 2024
View reviewed changes
Directory.Build.props Outdated Show resolved Hide resolved
@wtgodbe wtgodbe changed the base branch from main to release/9.0 September 11, 2024 22:15
@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Sep 11, 2024
MackinnonBuck
MackinnonBuck approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one question

Directory.Build.props Outdated Show resolved Hide resolved
@wtgodbe wtgodbe merged commit e476d9d into release/9.0 Sep 12, 2024
25 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/PackageReadme branch September 12, 2024 00:44
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-rc2 milestone Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MackinnonBuck MackinnonBuck MackinnonBuck approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
9.0-rc2
Development

Successfully merging this pull request may close these issues.

Produce NuGet package READMEs
2 participants
@wtgodbe @MackinnonBuck