Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Microsoft.AspNetCore.DataProtection.StackExchangeRedis package README #57825

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

MackinnonBuck
Copy link
Member

Contributes to #48392

@MackinnonBuck MackinnonBuck mentioned this pull request Sep 12, 2024
1 task
@amcasey
Copy link
Member

amcasey commented Sep 12, 2024

Thanks! This is awesome!

I wonder if it would be worthwhile to include this blurb or link: https://learn.microsoft.com/en-us/aspnet/core/security/data-protection/configuration/overview?view=aspnetcore-8.0#persisting-keys-with-redis. @mgravell might know more about whether it applies to this particular package.

@mgravell
Copy link
Member

Yes, I think the warning about persistence is important enough to include at this level; the warning could (as suggested) be lifted direct from the link provided - just that one line (it is a good line!).

@MackinnonBuck
Copy link
Member Author

Thanks, @mgravell and @amcasey! I've just updated the PR to include that warning.

@MackinnonBuck MackinnonBuck merged commit fc713dd into main Sep 13, 2024
23 checks passed
@MackinnonBuck MackinnonBuck deleted the mbuck/readme-dataprotection-stackexchangeredis branch September 13, 2024 16:05
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-dataprotection Includes: DataProtection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants