[release/9.0] Add explicit conversion for value-type returning handlers with filters #57967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #52128.
This PR fixes a bug with the handling of value type-returning handlers that are used in conjunction with endpoint filters. Such as:
This currently throws:
Because the return type requires an explicit conversion before being wrapped as a
ValueTask<object>
to confirm with the EndpointFilterDelegate's signature.Customer Impact
Without this bug fix, user applications that contain minimal API endpoints that return value types and use endpoint filters will fail to launch. Viable workarounds exist (for example, wrapping the value return in a
Results.Ok
), but they are difficult for the typical user to discover.Regression?
Risk
Scope of impact is limited to minimal APIs + endpoint filters + compile-time code generation.
Verification
Packaging changes reviewed?