Check for sentinel value when setting HTTP/3 error code #57976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no error code has been set, `IProtocolErrorFeature.Error` will be `-1`. If we pass that through verbatim, it will be caught by validation in the setter (ironically, of the same property on the same feature object), resulting in an exception and a Critical (but apparently benign) log message. Fixes dotnet#57933
amcasey
requested review from
halter73,
BrennanConroy,
JamesNK and
mgravell
as code owners
dotnet-issue-labeler
bot
added
the
area-networking
|
Approved over email |
JamesNK
approved these changes
Sep 20, 2024
This was referenced Sep 20, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for sentinel value when setting HTTP/3 error code
Detect when
IProtocolErrorFeature.Erroris unset and apply a default value.Description
If no error code has been set,
IProtocolErrorFeature.Errorwill be-1. If we pass that through verbatim, it will be caught by validation in the setter (ironically, of the same property on the same feature object), resulting in an exception and a Critical (but apparently benign) log message.Backport of #57934 (for #57933)
Customer Impact
When a connection times out, there's a critical log message. We're also not convinced the connection is properly cleaned up.
Subsequent requests should be unaffected.
HTTP/3 only.
Regression?
Regressed since 8.0 in #55282.
Risk
Replacing an invalid value (which will throw either in our code or in System.Net.Quic) with a valid code is a net improvement.
Verification
Packaging changes reviewed?