Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update global.json to 10.0 sdk #58425

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Update global.json to 10.0 sdk #58425

merged 3 commits into from
Oct 16, 2024

Conversation

BrennanConroy
Copy link
Member

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 14, 2024
@wtgodbe wtgodbe mentioned this pull request Oct 14, 2024
10 tasks
@wtgodbe
Copy link
Member

wtgodbe commented Oct 14, 2024

@BrennanConroy
Copy link
Member Author

How do we do that

@wtgodbe
Copy link
Member

wtgodbe commented Oct 14, 2024

Just need to add Microsoft.NETCore.App.Ref.9.0.0-preview.7.24405.7 to https://github.com/dotnet/aspnetcore/blob/main/eng/SourceBuildPrebuiltBaseline.xml, there's a link to the docs next to the failure in the build logs. SourceBuild uploads a generated new manifest to the build artifacts as a convenience

Screenshot 2024-10-14 at 1 27 08 PM

@BrennanConroy BrennanConroy marked this pull request as ready for review October 14, 2024 21:16
@BrennanConroy BrennanConroy requested review from a team and wtgodbe as code owners October 14, 2024 21:17
@MackinnonBuck MackinnonBuck requested a review from a team as a code owner October 15, 2024 20:35
@MackinnonBuck
Copy link
Member

Components E2E failures were due to the M.A.C.CustomElements project including the JS initializer module too late in the build process. This should now be fixed.

@halter73
Copy link
Member

Does this indicate there was a breaking change in the SDK? Could this break other targets currently configured to run before ResolveJSModuleStaticWebAssets like GenerateUnoWasmAssets, because they're now run too late? That's all I found using grep.app, but that only indexes a small fraction of Blazor code.

@MackinnonBuck
Copy link
Member

Does this indicate there was a breaking change in the SDK?

Yeah, it's possible. I looked through the most recent changes to the StaticWebAssets SDK and didn't see anything that should impact the build order. Maybe we got lucky in the past that this target ran in time, and something else was recently introduced that indirectly changed the target execution order.

@MackinnonBuck
Copy link
Member

cc @javiercn in case you have any thoughts or ideas about this

@javiercn
Copy link
Member

@MackinnonBuck I don't remember why the integration for this package was done this way.

Normally we tell people to depend on AssignTargetPaths which runs before our pipeline.

@BrennanConroy
Copy link
Member Author

Can we merge this then?

@BrennanConroy BrennanConroy merged commit 8c2f7db into main Oct 16, 2024
27 checks passed
@BrennanConroy BrennanConroy deleted the BrennanConroy-patch-2 branch October 16, 2024 16:43
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Oct 16, 2024
captainsafia pushed a commit that referenced this pull request Dec 31, 2024
captainsafia pushed a commit that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants