-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update global.json to 10.0 sdk #58425
Conversation
Looks like we need to add the new prebuilt until https://github.com/dotnet/sdk/blob/c2257cb5b1617ddf9b2654547fa221f91b00c4e0/src/Installer/redist-installer/targets/GenerateBundledVersions.targets#L88-L90 gets updated |
How do we do that |
Just need to add Microsoft.NETCore.App.Ref.9.0.0-preview.7.24405.7 to https://github.com/dotnet/aspnetcore/blob/main/eng/SourceBuildPrebuiltBaseline.xml, there's a link to the docs next to the failure in the build logs. SourceBuild uploads a generated new manifest to the build artifacts as a convenience ![]() |
Components E2E failures were due to the |
Does this indicate there was a breaking change in the SDK? Could this break other targets currently configured to run before |
Yeah, it's possible. I looked through the most recent changes to the StaticWebAssets SDK and didn't see anything that should impact the build order. Maybe we got lucky in the past that this target ran in time, and something else was recently introduced that indirectly changed the target execution order. |
cc @javiercn in case you have any thoughts or ideas about this |
@MackinnonBuck I don't remember why the integration for this package was done this way. Normally we tell people to depend on |
Can we merge this then? |
No description provided.