-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate a nuget package which contains the runtime pack for Microsoft.AspNetCore.App #7475
Conversation
Why? |
The SDK's .deps.json generation task requires a project.assets.json file, and it doesn't handle ProjectReference or native assets. I wrote the task to workaround these limitations. This will mean we can stop producing packages at all for assemblies that are shared framework only, like Mvc.dll. |
@natemcmaster If you want to put a locally-built copy of these packages on a share somewhere, I can test consuming them in the SDK. |
Build failure in PR:
Any ideas @jkotalik @pakrym? Is this something you see often? I periodically see issues like this with vcxproj. I think it's a race condition because retrying the build often makes it go away. |
I haven't seen this failure before but it's very likely a race because |
More flaky C++ build failures:
|
I think you are double building in this PR. It's slightly flaky but not this much. |
I don't think it's a double build of the same architecture. The binlogs show MSBuild doing the right thing and de-duplicates the build request. The errors show problems with files shared between x86 and x64 builds. |
Everything passed on retry except Helix. I'm looking into it more... |
It looks like Helix problems were unrelated to this change, but surfaced as a result of adding a new project. I've made some tweaks to the ways Helix builds add a dependency to xunit.runner.console (cc @HaoK ) |
a43ca96
to
9cc1575
Compare
01284fe
to
e905df1
Compare
…d files for managing dependencies
e905df1
to
6ac2db1
Compare
CI checks passed, and after running build 5 times, I haven't been able to get a repro of the flaky CI problems. If we run into this again, we can revert and investigate. I opened a bug for the flaky Helix test failure, but it appears unrelated to this change, so merging now. |
Part of #6501
Changes:
TODO (in a separate PR)
cref dotnet/designs#50
cc @dsplaisted @nguerrera @dagood