Fix portable PDB stamp in CodeView header #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous fix for deterministic PDB ID wrote the PDB stamp as the PDB Age field. This change fixes it to write the stamp as the stamp field of the CodeView header nad writes the PDB Age as 1 always. Added tests.
|
@marek-safar @agocke could you please review? |
|
This should fix the failure seen in dotnet/runtime#61669. |
marek-safar
approved these changes
Nov 29, 2021
|
You'll add that to jbevain#810 right? |
|
@akoeplinger Absolutely - already done. |
vitek-karas
added a commit
to vitek-karas/linker
that referenced
this pull request
Nov 29, 2021
vitek-karas
added a commit
to dotnet/linker
that referenced
this pull request
Nov 30, 2021
marek-safar
pushed a commit
that referenced
this pull request
Jan 20, 2022
* Fix deterministic MVID and add PdbChecksum (#31) * Fix how pdb path is calculated in the tests * Fix portable PDB stamp in CodeView header (#32) * Introduce ISymbolWriter.Write This mostly cleans up the code to make it easier to understand. `ISymbolWriter.GetDebugHeader` no longer actually writes the symbols, there's a new `Write` method for just that. The assembly writer calls `Write` first and then the image writer calls `GetDebugHeader` when it's needed. This is partially taken from jbevain#617.
marek-safar
added a commit
that referenced
this pull request
Jan 20, 2022
This reverts commit e04f141.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous fix for deterministic PDB ID wrote the PDB stamp as the PDB Age field. This change fixes it to write the stamp as the stamp field of the CodeView header and writes the PDB Age as 1 always.
Added tests.
Also includes a test fix which was discovered by trying to merge the previous change into jbevain/cecil.