Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify RuntimeEnvironment to use System.Runtime.InteropServices.RuntimeInformation #5911

Closed
pranavkm opened this issue Apr 29, 2016 · 7 comments
Milestone

Comments

@pranavkm
Copy link
Contributor

The code ported from Microsoft.Extensions.PlatformAbstractions contains a bunch of pinvokes for APIs that are available via the RuntimeInformation package. However the package has issues in RC2 where it does not bring in runtime binaries in desktop applications. This is fixed in RTM (https://github.com/dotnet/corefx/issues/7863).

@TheRealPiotrP
Copy link
Contributor

I looked at the dependencies of Microsoft.Extensions.PlatformAbstractions. It does not have any dependencies back into CLI, so as long as the package references shipping CoreFx packages I don't have concern about the cycle for RC2.

@TheRealPiotrP
Copy link
Contributor

since the PR is out, let's leave this in :)

@TheRealPiotrP
Copy link
Contributor

Per conversation with @pranavkm this is tracking remaining work for RTM which will enable using RuntimeInformation in desktop projects. This is dependent on dotnet/corefx#7863 and so will be fixed in RTM once that is fixed.

@pranavkm
Copy link
Contributor Author

pranavkm commented Jun 1, 2016

I was looking at this again and there's a bunch of APIs in RuntimeInformation that we require (Unix distro name, OsVersion) that are internal to corefx. I'll file a work item to see if they are willing to make these APIs usable to us.

@pranavkm
Copy link
Contributor Author

pranavkm commented Jun 1, 2016

Here's the CoreFx work item: https://github.com/dotnet/corefx/issues/9011.

@pranavkm pranavkm removed their assignment Aug 29, 2016
@TheRealPiotrP
Copy link
Contributor

The CoreFx issue is still open, so moving this out of RTM.

@livarcocc
Copy link
Contributor

We don't ship this out of the CLI anymore.

@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the Backlog milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants