Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Directive Symbol type #2063

Merged
merged 15 commits into from
Mar 7, 2023
Merged

Commits on Feb 21, 2023

  1. define Directive symbols

    adamsitnik committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    0d76a52 View commit details
    Browse the repository at this point in the history
  2. tokenization

    adamsitnik committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    8ce5271 View commit details
    Browse the repository at this point in the history
  3. parsing

    adamsitnik committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    3a24a45 View commit details
    Browse the repository at this point in the history
  4. configuration

    adamsitnik committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    ac851d3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d39fe8f View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Configuration menu
    Copy the full SHA
    47f9a89 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7127bc2 View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'upstream/main' into directives

    # Conflicts:
    #	src/System.CommandLine.ApiCompatibility.Tests/ApiCompatibilityApprovalTests.System_CommandLine_api_is_not_changed.approved.txt
    #	src/System.CommandLine.Benchmarks/CommandLine/Perf_Parser_ParseResult.cs
    #	src/System.CommandLine.Tests/DirectiveTests.cs
    #	src/System.CommandLine/Builder/CommandLineBuilder.cs
    #	src/System.CommandLine/Builder/CommandLineBuilderExtensions.cs
    #	src/System.CommandLine/CommandLineConfiguration.cs
    #	src/System.CommandLine/Invocation/ParseDirectiveResult.cs
    #	src/System.CommandLine/Invocation/SuggestDirectiveResult.cs
    #	src/System.CommandLine/ParseResult.cs
    #	src/System.CommandLine/Parsing/ParseOperation.cs
    adamsitnik committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    da63f85 View commit details
    Browse the repository at this point in the history
  4. exclude private protected properties, as Relative_order_of_arguments_…

    …and_options_within_a_command_does_not_matter was calling Directive.GetDefaultName and throwing
    adamsitnik committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    96876bc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f200208 View commit details
    Browse the repository at this point in the history
  6. the reference to "this" can't be used when calling base class ctor

    introduce public APIs for setting the handler to make it possible to use reference to "this" in Directive handlers
    adamsitnik committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    484bc57 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. provide more flexible mechanism for directive handlers: possibility t…

    …o pass next handler and invoke it or not
    adamsitnik committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    fc987d4 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. Revert "provide more flexible mechanism for directive handlers: possi…

    …bility to pass next handler and invoke it or not"
    
    This reverts commit fc987d4.
    adamsitnik committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    ea619bf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f37d8df View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Merge remote-tracking branch 'upstream/main' into directives

    # Conflicts:
    #	src/System.CommandLine.ApiCompatibility.Tests/ApiCompatibilityApprovalTests.System_CommandLine_api_is_not_changed.approved.txt
    #	src/System.CommandLine.Tests/DirectiveTests.cs
    #	src/System.CommandLine/Parsing/StringExtensions.cs
    #	src/System.CommandLine/Parsing/SymbolResultExtensions.cs
    adamsitnik committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    8f16b15 View commit details
    Browse the repository at this point in the history