This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix alpine linux RID graph generation #3483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alpine Linux doesn't have 'linux' in its hierarchy, so the GenerateRuntimeGraph target doesn't output alpine node to the runtimes section of the Microsoft.NETCore.App.deps.json. This change is a hotfix to that issue. In longer term, we should create a new osgroup named `alpine` or maybe better `linuxmusl` or something along these lines and make it a fully supported OS group everywhere.
janvorli
added
area-Setup
bug
|
@eerhardt it seems there is a problem with this change on Alpine, please do not merge it until I verify it. |
janvorli
added
* NO MERGE *
|
@eerhardt the fix for Alpine rid parent in corefx fixed the issue I was having, so this PR is ready to review / merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alpine Linux doesn't have 'linux' in its hierarchy, so the
GenerateRuntimeGraph target doesn't output alpine node to the runtimes
section of the Microsoft.NETCore.App.deps.json.
This change is a quick fix to that issue to unblock my work on enabling building of CLI for Alpine.
In longer term, we should create a new osgroup named
alpineor maybe betterlinuxmuslor somethingalong these lines and make it a fully supported OS group everywhere.