This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Updating arch support for arm #4085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Petermarcu
changed the title
|
I haven't been able to build and test locally on different arch's so marking this a no merge. |
eerhardt
approved these changes
Apr 27, 2018
There was a problem hiding this comment.
LGTM.
It looks like the host already has the correct code for ARM architectures, so we should be good there:
core-setup/src/corehost/common/utils.cpp
Lines 187 to 200 in 4b628f4
ghost
reviewed
Apr 27, 2018
| return $"-{RuntimeArchitecture.ToLowerInvariant()}"; | ||
| } | ||
| return string.Empty; | ||
| return $"-{RuntimeArchitecture}"; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Petermarcu
changed the title
|
Finished verifying this on my Pi and confirmed we now have the correct behavior. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for arm and arm64 rids to address https://github.com/dotnet/core-setup/issues/4081