Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Use Version suffix and clean versions #8724

Merged
merged 6 commits into from
Nov 1, 2019

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Nov 1, 2019

Requires dotnet/arcade#4266

I'm consolidating all the version properties to use the Version suffix instead of PackageVersion. This aligns to Arcade conventions and extension point which also use the Version suffix.

  • Cleaning the unused dependencies in Version.Details.xml and the sourcelink one as that one is pushed down by arcade.
  • Removing the MicrosoftDotNetMaestroTasksVersion which is set in Arcade as well.
  • Removing unused package names.
  • Use package names which are defined in Versions.props in the code.
  • Consolidate on using Version suffix everywhere (corefx, coreclr, core-setup, arcade)

@ViktorHofer ViktorHofer self-assigned this Nov 1, 2019
@ViktorHofer ViktorHofer force-pushed the CleanBARVersions branch 2 times, most recently from 6f9e71b to 5d5e022 Compare November 1, 2019 11:50
@ViktorHofer ViktorHofer changed the title Use PackageVersion suffix and clean versions Use Version suffix and clean versions Nov 1, 2019
Copy link
Member

@dagood dagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plan seems fine. netstandard.library change seems weird though.

eng/Versions.props Show resolved Hide resolved
@ViktorHofer ViktorHofer merged commit 17b71d2 into dotnet:master Nov 1, 2019
@ViktorHofer ViktorHofer deleted the CleanBARVersions branch November 1, 2019 16:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants