Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Avoid importing an Arcade extension point #8823

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Conversation

ViktorHofer
Copy link
Member

Importing Subsets.props instead of Build.props allows to avoid duplicate Imports in the runtime repository without any project renames or other condition hacks. Also in general we should avoid importing an Arcade extension point.

@ViktorHofer ViktorHofer self-assigned this Nov 11, 2019
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@dagood dagood merged commit e081748 into master Nov 11, 2019
@dagood dagood deleted the ViktorHofer-patch-1 branch November 11, 2019 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants